-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tlg4090.tlg002 (incomplete) #2074
base: master
Are you sure you want to change the base?
Conversation
Merging the master branch from OGL
Edited tlg4090.tlg002 (incomplete)
Hi, how can I check the problems with this file? |
If you click on the "Details" link next to the failed test (in this case "continuous-integration/travis-ci/pr"), then it will take you to a page where you can check what failed. In this case, it looks like a lot of the tests failed. I will try to take a closer look at this when I have time. |
Hi @Cami33, I will try to tackle a few of the issues I see here. First, I think that the file name tlg4090.tlg002.1st1K-grc1 (volume 1).xml is not allowed. Are looking to call this tlg4090.tlg002.1st1K-grc1.xml? Is that correct? In any case, your CTS work file has one file name and your actual work file goes by another so that needs to be resolved. The parenthetical has to be removed or otherwise resolved and we have to make sure the file name is what it should be. The next thing I see is, following on the file naming issue, that there is an incomplete whereas I expect the first These two issues are why Hook reads |
Hi again, @Cami33 I am now looking at the cts work file. There are some little inconsistencies to the way we work on these at Perseus, so I will ignore those and focus on what may be breaking the Hook tests. Immediately, this jumps out at me The curly quotes here are not allowed. I think there are more later on in the file, so check for those. Let's see if 1) fixing the file name and 2) fixing the curly quotes permits the cts work file to pass. |
I've tried to work on this file which was not complete, and added the metadata on the file level