Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlg4090.tlg002 (incomplete) #2074

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Cami33
Copy link
Contributor

@Cami33 Cami33 commented Mar 26, 2018

I've tried to work on this file which was not complete, and added the metadata on the file level

@Cami33 Cami33 closed this Apr 3, 2018
@Cami33 Cami33 reopened this Apr 3, 2018
@Cami33
Copy link
Contributor Author

Cami33 commented Apr 10, 2018

Hi, how can I check the problems with this file?

@sonofmun
Copy link
Contributor

If you click on the "Details" link next to the failed test (in this case "continuous-integration/travis-ci/pr"), then it will take you to a page where you can check what failed. In this case, it looks like a lot of the tests failed. I will try to take a closer look at this when I have time.

@lcerrato
Copy link
Collaborator

Hi @Cami33,

I will try to tackle a few of the issues I see here.

First, I think that the file name tlg4090.tlg002.1st1K-grc1 (volume 1).xml is not allowed. Are looking to call this tlg4090.tlg002.1st1K-grc1.xml? Is that correct? In any case, your CTS work file has one file name and your actual work file goes by another so that needs to be resolved. The parenthetical has to be removed or otherwise resolved and we have to make sure the file name is what it should be.

The next thing I see is, following on the file naming issue, that there is an incomplete <div> under the <body> tag in the text itself.
You have
<body>
<div type="bibliography">

whereas I expect the first <div> to declare three things: type, language, and the n attribute.
for example:
<div type="edition" xml:lang="grc" n="urn:cts:greekLit:tlg4090.tlg002.1st1K-grc1">

These two issues are why Hook reads Naming convention failed or Naming conventions as errors.

@lcerrato
Copy link
Collaborator

lcerrato commented Apr 26, 2018

Hi again, @Cami33

I am now looking at the cts work file. There are some little inconsistencies to the way we work on these at Perseus, so I will ignore those and focus on what may be breaking the Hook tests.

Immediately, this jumps out at me
<ti:work xmlns:ti="http://chs.harvard.edu/xmlns/cts" groupUrn="urn:cts:greekLit:tlg4090” xml:lang="grc" urn="urn:cts:greekLit:tlg4090.tlg002 (volume 1)”>

The curly quotes here are not allowed.

I think there are more later on in the file, so check for those.

Let's see if 1) fixing the file name and 2) fixing the curly quotes permits the cts work file to pass.

@lcerrato lcerrato added the Legacy Older OGL work label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy Older OGL work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants