Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tlg0018) Adding Tag Citations #2764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdeen33
Copy link

@jdeen33 jdeen33 commented Aug 13, 2023

added tags for book, section, and sentences, as well as segmented the text by sentence

added tags for book, section, and sentences, as well as segmented the text by sentence
@lcerrato lcerrato changed the title Adding Tag Citations (tlg0018) Adding Tag Citations Aug 21, 2023
@lcerrato
Copy link
Collaborator

@jdeen33
Can you further explain this work? It appears we have a bunch of files removed and renamed. We also don't generally do PRs with hundreds of files and changes as that unfortunately makes reviews challenging.

Also, when you rename a file you take away the ability to see the differences in the previous file, so the link between the version is severed and diff'ing the files is broken. Is there a reason for the file renaming with the "edited" appended?

None of the files include a header explanation of the changes or the purpose: this would be required in the <change> log of the <revisionDesc> for such an extensive set of edits.

I would also recommend that if another division was added, then the structure should reflect that. For instance book/section/sentence could be the containers here (or part? I see book referenced above and part referenced in the files).

As of right now, these files will be removed from the repository with this PR so we will be going from 1242 files to 1180. Is that the intent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants