Update requirements files with newer pip-tools #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how pip-tools handles formatting, this looks like a major change but is actually just "moving comments around".
|
@gedankenstuecke I scanned pretty thoroughly... as far as I can tell, there's no "actual" changes. Just a change in formatting. (And there's no option to use "old style", but of course there is an issue requesting it... 😂 ) |
|
@madprime link the issue? |
The update to the requirements files was a product of the update to pip-tools, added here, which I found necessary due to updates in pip.
gedankenstuecke
approved these changes
Jul 28, 2021
|
@abitrolly If you're wondering what the pip-tools issue I referred to was, I think it was this one: jazzband/pip-tools#1306 I'm happy to switch over to the new formatting (I'm not sure I'd use this option if it were available), but I can see from the discussion there that there are various reasons folks would prefer to have the old style option still available. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how pip-tools handles formatting, this looks like a
major change but is actually just "moving comments around".