Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.c: Add exec support to OIDCClientSecret #1056

Merged

Conversation

sealor
Copy link
Contributor

@sealor sealor commented May 5, 2023

I noticed that there is an "exec" support available for OIDCCryptoPassphrase and OIDCClientTokenEndpointKeyPassword. I need a similar feature for OIDCClientSecret to retrieve the secret from a secured location.

So, I propose adding this also for OIDCClientSecret.

The current implementation does not allow passphrases, passwords and secrets starting with "exec:". Perhabs, this could be fixed by adding new configuration parameters like OIDCCryptoPassphraseExec, OIDCClientTokenEndpointKeyPasswordExec and OIDCClientSecretExec. What do you think about this approach?

@zandbelt
Copy link
Member

zandbelt commented May 5, 2023

thank you for the contribution! I'd prefer to keep things as they are - to avoid cluttering the configuration file with even more primitives - and take the risk that you mention

@zandbelt
Copy link
Member

zandbelt commented May 5, 2023

please add an entry to the ChangeLog and add yourself to the AUTHORS file as well, thanks

@sealor sealor force-pushed the add_exec_support_to_OIDCClientSecret branch from 1637c90 to 1e83468 Compare May 5, 2023 18:55
@sealor
Copy link
Contributor Author

sealor commented May 5, 2023

@zandbelt
Thank you for your fast feedback! I added an entry to ChangeLog and AUTHORS as mentioned.

@zandbelt zandbelt merged commit 37ead29 into OpenIDC:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants