Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos-gate: alternate way to handle /32 packages #19419

Open
wants to merge 1 commit into
base: oi/hipster
Choose a base branch
from

Conversation

Bill-Sommerfeld
Copy link
Contributor

No description provided.

@mtelka
Copy link
Contributor

mtelka commented Nov 3, 2024

This change is not needed now because the illumos-gate component builds okay. I propose to postpone the merge until the https://www.illumos.org/issues/16879 gets fixed upstream. After the https://www.illumos.org/issues/16879 fix upstream we will very likely need to do something here anyway, so better to do it once instead of twice, I think.

@Bill-Sommerfeld
Copy link
Contributor Author

This change is not needed now because the illumos-gate component builds okay. I propose to postpone the merge until the https://www.illumos.org/issues/16879 gets fixed upstream.

I was hoping that this would integrate here sooner so I could point to it as part of the testing for https://www.illumos.org/issues/16879 when I file the RTI.

After the https://www.illumos.org/issues/16879 fix upstream we will very likely need to do something here anyway, so better to do it once instead of twice, I think.

Once 16879 lands upstream it should be sufficient to delete 0009-bug16879.patch

@mtelka
Copy link
Contributor

mtelka commented Nov 3, 2024

This change is not needed now because the illumos-gate component builds okay. I propose to postpone the merge until the https://www.illumos.org/issues/16879 gets fixed upstream.

I was hoping that this would integrate here sooner so I could point to it as part of the testing for https://www.illumos.org/issues/16879 when I file the RTI.

Interesting idea. But for materialize that you would need to wait for the next illumos-gate rebuild. It is unclear when it will happen. Anyway, your local nightly should be more than enough for the RTI.

After the https://www.illumos.org/issues/16879 fix upstream we will very likely need to do something here anyway, so better to do it once instead of twice, I think.

Once 16879 lands upstream it should be sufficient to delete 0009-bug16879.patch

Yes. Provided it lands in the shape as it is currently proposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants