[IMP] run_cmd logging

OpenJKSoftware · Nov 22, 2023 · adeea2f · adeea2f
1 parent 923d5a2
commit adeea2f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/godoo_cli/commands/backup/load.py b/src/godoo_cli/commands/backup/load.py
@@ -49,11 +49,11 @@ def load_pg_dump(
         command = "cat %s | psql {} >/dev/null" % dump_path
     load_return = conn.run_psql_shell_command(
         command=command,
-        log_name="Reading DB",
         text=True,
         capture_output=True,
     )
     if load_return.returncode != 0:
+        LOGGER.error("Failed to load DB Dump: %s", load_return.stderr)
         raise typer.Exit(1)
     LOGGER.info("Deleting RPC Import Cache using plain SQL")
     with conn.connect() as cur:

diff --git a/src/godoo_cli/helpers/system.py b/src/godoo_cli/helpers/system.py
@@ -19,7 +19,7 @@
 LOGGER = logging.getLogger(__name__)
 
 
-def run_cmd(command: str, log_name: str = "", **kwargs) -> subprocess.CompletedProcess:
+def run_cmd(command: str, **kwargs) -> subprocess.CompletedProcess:
     """Runs command via subprocess.run
 
     Parameters
@@ -37,8 +37,7 @@ def run_cmd(command: str, log_name: str = "", **kwargs) -> subprocess.CompletedP
     if not kwargs.get("shell"):
         kwargs["shell"] = True
     proc = subprocess.run(command, **kwargs)
-    if proc.returncode != 0 and log_name:
-        LOGGER.error("Failed: %s", log_name)
+    LOGGER.debug("Return Code: %s", proc.returncode)
     return proc