chore: Change default windows working directory to the "C:\ProgramData\Amazon" #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honglichenn
force-pushed
the
honglich/tmp_dir
branch
from
05f7ffb
to
74f3ed7
Compare
roblutt
reviewed
Jan 30, 2024
ddneilson
requested changes
Jan 30, 2024
Honglichenn
force-pushed
the
honglich/tmp_dir
branch
from
74f3ed7
to
6d24034
Compare
Honglichenn
force-pushed
the
honglich/tmp_dir
branch
from
6d24034
to
f8c8339
Compare
roblutt
reviewed
Jan 30, 2024
Honglichenn
force-pushed
the
honglich/tmp_dir
branch
2 times, most recently
from
387b299
to
334dca0
Compare
…a\Amazon" Signed-off-by: Hongli Chen <[email protected]>
Honglichenn
force-pushed
the
honglich/tmp_dir
branch
from
334dca0
to
e038739
Compare
roblutt
approved these changes
Jan 31, 2024
ddneilson
approved these changes
Jan 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Before this change, the default path is generated by gettempdir(), which is returning a temporary directory within the current user's profile. For example,
C:\Users\UserA\AppData\Local\Temp\That's undesirable because that means that in the cross-user case we're giving a 2nd user access to a directory within the 1st user's profile.
What was the solution? (How)
Change the default tmp dir to the
C:\ProgramData\AmazonWhat is the impact of this change?
Default tmp dir will be changed to the
C:\ProgramData\AmazonHow was this change tested?
A new integration test is added.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.