Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom shader to simulate PS2 behaviours #118

Merged
merged 8 commits into from
May 30, 2020
Merged

Conversation

Xeeynamo
Copy link
Contributor

This fixes some of the odd texture rendering glitches caused by the inability of emulating the "Texture Wrap Mode" as PlayStation 2 internally does.

BEFORE
before

AFTER
after

@Rikux3
Copy link
Contributor

Rikux3 commented May 29, 2020

Out of curiosity: What causes these "smudges" in the skybox? I've found them on another map too.
grafik

@Xeeynamo
Copy link
Contributor Author

I think it is a regression caused by the custom VIF interpreter I wrote before merging the engine into master. I am going to confirm later in the day if it is caused by the a regression of this pull request or somewhere else.

@Xeeynamo
Copy link
Contributor Author

The "smudge" bug is definitively caused by VifUnpacker, which sets the wrong v coordinate to the mesh. I reached this conclusion by verifying the wireframe and comparing (see the screenshot below) before and after this pull request:
image

I will look into it outside this pull request, since it is not related to the shader I've introduced here.

@Rikux3 Rikux3 merged commit 01f906f into master May 30, 2020
@Rikux3 Rikux3 deleted the feature/kingdom-shader branch May 30, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants