Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00battle Editor and Docs #128

Merged
merged 107 commits into from
Jun 2, 2020
Merged

00battle Editor and Docs #128

merged 107 commits into from
Jun 2, 2020

Conversation

Rikux3
Copy link
Contributor

@Rikux3 Rikux3 commented May 31, 2020

There are still sub-files missing, but we did the same with the System editor, so i think we should still merge this.

Rikux3 and others added 30 commits July 28, 2019 20:20
Bons and Przt + Tests
cfe13b2
Vtbl file format
385d4a9 
Based on http://crazycatz00.x10host.com/KH/kh2_spec_formats.html
@Xeeynamo
Add documentation for LVPM and ENMP
9ca2a74
@Xeeynamo
Add some 00battle tests
600e325
@Xeeynamo
Add foundation for Kh2 Battle Editor
96e1b88
@Xeeynamo
Add open and save editor functionalities for 00battle.bin
9c79173
@Xeeynamo
Add skeleton for 00battle editing support
1ad4df0
@Xeeynamo
Add enemy list with filtering
d25484d
@Xeeynamo
Add enemy name provider
0ed148a
@Xeeynamo
Update XeEngine.Tools.Public
e54dcfb
@Xeeynamo
Add Enmp editing
33200f9
Merge branch 'feature/00battle-bons-przt-vtbl' into feature/00battle
f477e97
Bons, Przt, Vtbl now use BaseBattle
50b07f9
Move Lvup to Battle directory
7cef923
Updated Tests to run properly
f631860
Update XeEngine.Tools.Public
9c3a0a4
@Rikux3
Fmlv in BinaryMapper format
00d4c60
@Rikux3
whatever
2cfad79
@Rikux3
Fmlv view + view model
e92beaa
@Rikux3
Provider for form names
83cd446
@Rikux3
Add fmlv tab to main view
3169374
@Rikux3
remove old fmlv implementation in favor of new
e293a2e
@Rikux3
new tests for new fmlv implementation
5bf8a9b
@Rikux3
Updated Bons structure
9807d5a
@Rikux3
Rename RewardIndex => RewardId
7b65485
@Rikux3
BonsView (mostly c&p from EnmpView)
5023562
@Rikux3
Add Bons view to main window
b7819ff
@Rikux3
Show reward id as textblock in hex form
c531daa
@Rikux3
started lvup implementation in binarymapper format, not working right…
209a4c8 
… now
@Rikux3
first draft of plrp
7cd91da
Rikux3 and others added 21 commits May 31, 2020 02:08
@Rikux3
documentation for przt, bons, plrp
898200d
@Rikux3
damn i should save more often
59bc360
@Rikux3
that field is a byte
0687ee0
@Rikux3
fixed a typo
9c57951
@Rikux3
fixed navigation
019d12d
@Truthkey @Rikux3
Update 00battle.md
99cf9f6 
I updated Bons and Lvup with more precise information.
@Rikux3
Revert "Merge branch 'feature/00battle' of https://github.com/Xeeynam…
00a31df 
…o/OpenKh into feature/00battle"

This reverts commit fc1dc0e, reversing
changes made to 409f158.
@Rikux3
Restore Truthkey's changed cause i've messed up
85dc768
@Rikux3
Lvup: commit this only for traceability
20ecdbb 
Will be moved into Lvup next commit
@Rikux3
Lvup: Refactoring
c621d08
@Rikux3
Lvup: Add views from LevelUp Editor
70f3508
@Rikux3
Remove old LevelUpEditor, it's obsolete now
60e224e
@Rikux3
Upgrade to .Net Core 3.1
d645f4e
@Rikux3
Lvup: Add Margin to textblocks
19f5787
@Rikux3
Lvup: Resolve rebasing artifacts
951f2d7
@Rikux3
Merge branch 'feature/00battle' of https://github.com/Xeeynamo/OpenKh …
6f49059 
…into feature/00battle
@Rikux3
Bar EntryTypes have been shifted, use EntryType List
283a5de
@Rikux3
Use Bar.EntryType.List instead of Binary
eae126e
@Rikux3
Fmlv: Change ViewModels to accomodate the new structure
1a1b8a8
@Rikux3
Lvup: Change view so it's consistent with Fmlv
6ac0ce4
@Rikux3
Fix failing tests
2ed58f2
Xeeynamo
Xeeynamo suggested changes May 31, 2020
View reviewed changes
Copy link
Contributor

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that OpenKh.Tools.CtdEditor\App.xaml.cs is broken. I will review everything else ASAP

@Rikux3
Copy link
Contributor Author

Rikux3 commented May 31, 2020

Sorry about that. As i've mentioned earlier, i might have made errors while rebasing this branch. Should be fixed now.

@Xeeynamo
Copy link
Contributor

Xeeynamo commented Jun 2, 2020

All good! The tool is very useful and it gives loads of modding features we were previously unaware of.

There are some tweaks that would be ideal to see in the future. But let's take them as just a wish-list:

  • Abilities could have their real name rather than just an ID
  • Group characters on the Bonus level tab
  • Show the EXP required to level up as a linear graph and avoid to insert a lower value than the previous level.

@Xeeynamo Xeeynamo merged commit a2ce79e into master Jun 2, 2020
@Xeeynamo Xeeynamo deleted the feature/00battle branch June 2, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xeeynamo Xeeynamo Xeeynamo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rikux3 @Xeeynamo @Truthkey