-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2d drawing improvements #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various graphics glitches and removes
Xe.Drawing
dependency for good.All the game maps were suffering from a bug where transparent elements were not blended correctly with the skybox. This problem has been fixed as the screenshot proves:
There is also another fixed bug, where the game engine was always loading the skybox as SK0, but maps like tt00 have the skybox as SK1
The improved Sequence rendering engine now process loops correctly thanks to my recent discovery. I removed some hard-coded logic to loop certain sequences in the TitleScreen since they were no longer necessary.
Thanks to @kenjiuno discovery regarding the blending mode, I was able to improve the rendering system even more to correctly render complex sequences like the title screen:
Finally, thanks to my recent discovery of sequence being capable to perform UV animations, I was able to replicate this in-game too, and it looks fantastic:
The title screen is still not perfect, as the additive blending mode is brightening the screen too much.
Also, since the game is using MonoGame and the tools Direct3D, the blending mode and UV animations has only been implemented in MonoGame. Therefore those two specific fixes will not be available (yet) in the LayoutEditor tool. The main reason is because I have yet to do some research on how to write a shader for it.