Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text importers/exporters #82

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Conversation

kenjiuno
Copy link
Collaborator

@kenjiuno kenjiuno commented Feb 21, 2020

Implement text exporters #58:

  • txt
  • csv
  • xml
  • yml

Main menu:

2020-02-21_23h44_48

Format filters:

2020-02-21_23h45_20

Copy link
Collaborator

@Vladabdf Vladabdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks great! Before the pull request gets merged, are you currently planning on making the importer functional soon? If so, I'll wait to merge until that's complete just so make things a little simpler.

@kenjiuno
Copy link
Collaborator Author

@Vladabdf Thanks for checking detail parts!

I have implemented 3 text importers: csv/xml/yml

2020-02-25_22h43_19

2020-02-25_22h41_04

If no text decoder matched (like passing txt, bar or something), error will be prompted.

2020-02-25_22h40_19

@kenjiuno kenjiuno changed the title Implement text exporters Implement text importers/exporters Feb 25, 2020
Copy link
Collaborator

@Vladabdf Vladabdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and the import and export functions work beautifully! Thank you very much for your contribution!

@Vladabdf Vladabdf merged commit b4b1167 into OpenKH:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants