-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Objentry additions #95
Conversation
It controls the inventory and command menu options that the Object has access to. Erkz
* Update object type with names from elf * Add explanation about command menu options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good with an exception IMHO:
On Objentry.cs:59
, by specifying an empty description would not lead to an empty label? If you speicfy a [Description]
rather than [Description("")]
would make it fall back to E_OBJ
by default. I did not tested it, so could you confirm if the behaviour is the one you expect to see?
Also I've seen you're having fun with C# Reflection for the Objentry.Clone()! While I do not see any problem in this specific scenario, people on internet can slightly disagree on its usage due to performance or possible bugs. One of them, for example would be if the property does not have a setter, making the field.SetValue
fail at runtime and not at compilation time.
But since this is just an opinion not related to this scenario, I would keep as it is in your Pull Request!
I didn't like the way i've implemented the |
Looks good 👍 |
Updated some previous unknown fields and the documentation