<springBootApplication/> issue fix #1844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n server.xml <springBootApplication/> node Signed-off-by: Arun Venmany <[email protected]>
cherylking
requested changes
Nov 15, 2024
There was a problem hiding this comment.
I think the changes are good, but we need some negative tests added.
- More than one springBootApplication element specified to trigger the exception. Need to use invoker.properties for that.
- Specify the
appsfolder but do not provide the configuration for the springBootApplication and test that the config gets generated in the configDropins folder.
Signed-off-by: Arun Venmany <[email protected]>
cherylking
requested changes
Nov 18, 2024
| <featureManager> | ||
| <feature>appSecurityClient-1.0</feature> | ||
| <feature>jaxws</feature> | ||
| <platform>badname</platform> |
There was a problem hiding this comment.
Why do you have a bad platform name here? And I don't see multiple springBootApplication elements here which is what the test is supposed to be for.
| @@ -27,6 +27,9 @@ public void testThinApplicationExistsInAppsDirectory() throws Exception { | |||
|
|
|||
| File f = new File("target/liberty/wlp/usr/servers/test/apps/thin-springboot-3-appsdirectory-apps-it-1.0.0.Final-exec.jar"); | |||
| assertTrue(f.getCanonicalFile() + " doesn't exist. Plugin failed to place the file at right destination.", f.exists()); | |||
| File f2 = new File("target/liberty/wlp/usr/servers/test/configDropins/defaults"); | |||
| assertTrue(f2.getCanonicalFile() + " folder doesn't exist. Plugin failed to create the config dropins folder ", f2.exists()); | |||
| assertTrue(f2.getCanonicalFile() + " folder doesn't contain any files. Plugin failed to place config xml at right destination.", f2.list().length == 1); | |||
There was a problem hiding this comment.
Can we verify the contents of the generated file?
| @@ -9,6 +9,9 @@ switch (testname) { | |||
| case "kernel-install-versionless-feature-fail-no-platform-it": | |||
| expectedMessage = "CWWKF1516E: The platform could not be determined. The following versionless features cannot be installed: [servlet]"; | |||
| break; | |||
| case "springboot-3-deploy-multiple-springboot-application-nodes-fail-it": | |||
There was a problem hiding this comment.
If we are going to add other tests to this script, we should rename it probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making change to create thin application with same name as provided in server.xml node