Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4493 Reactive Streams Unit Tests #6617

Merged
merged 3 commits into from
Feb 25, 2019
Merged

4493 Reactive Streams Unit Tests #6617

merged 3 commits into from
Feb 25, 2019

Conversation

hutchig
Copy link
Contributor

@hutchig hutchig commented Feb 20, 2019

Unit tests for the Reactive Stream Operators RxJava implementation.

@hutchig
RxJava in junits
29ac966 
Signed-off-by: Gordon Hutchison <[email protected]>
@hutchig
Some more unit tests
77241cc 
Signed-off-by: Gordon Hutchison <[email protected]>
@hutchig
added javadoc to reactive streams unit tests
4143362 
Signed-off-by: Gordon Hutchison <[email protected]>
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 11 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@hutchig hutchig changed the title 4493 rso ut 1 4493 Reactive Streams Unit Tests 1 Feb 20, 2019
@hutchig
Copy link
Contributor Author

hutchig commented Feb 20, 2019

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_5d5gITUsEemUn-nbjMTX6w

Target locations of links might be accessible only to IBM employees.

tevans78
tevans78 approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@tevans78 tevans78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hutchig
Copy link
Contributor Author

hutchig commented Feb 21, 2019

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_iHFIQDW8EemUn-nbjMTX6w

Target locations of links might be accessible only to IBM employees.

@hutchig
Copy link
Contributor Author

hutchig commented Feb 21, 2019

First build was abandoned

@hutchig hutchig changed the title 4493 Reactive Streams Unit Tests 1 4493 Reactive Streams Unit Tests Feb 21, 2019
@LibbyBot
Copy link

Your Open Liberty build results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_iHFIQDW8EemUn-nbjMTX6w. There might be a brief delay before results are available.

@Emily-Jiang Emily-Jiang mentioned this pull request Feb 21, 2019
Closed
@LibbyBot
Copy link

The build hutchig-6617-20190221-1048
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_iHFIQDW8EemUn-nbjMTX6w
completed successfully!

hutchig
hutchig commented Feb 22, 2019
View reviewed changes
...treams.operators/test/src/com/ibm/ws/microprofile/reactive/streams/test/RsoElementsTest.java
public void testReactiveStreamsDotOrgProcessor() throws InterruptedException {

PublisherBuilder<Integer> data = ReactiveStreams.of(1, 2, 3, 4, 5);
UnicastProcessor<Integer> rxProc = UnicastProcessor.create();
Copy link
Contributor Author

@hutchig hutchig Feb 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to create a Processor out of an RxJava operator.

@hutchig hutchig merged commit 92b7230 into OpenLiberty:integration Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevans78 tevans78 tevans78 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hutchig @LibbyBot @tevans78