-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][Airflow] Support OL Datasets in manual lineage inputs/outputs #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
conorbev
force-pushed
the
manual-lineage-dataset
branch
from
August 15, 2022 16:22
437b6a6
to
b610034
Compare
JDarDagran
requested changes
Aug 16, 2022
integration/airflow/openlineage/airflow/extractors/bash_extractor.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Conor Beverland <[email protected]>
Signed-off-by: Conor Beverland <[email protected]>
JDarDagran
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Conor Beverland [email protected]
Problem
The current support for manual lineage definition requires a user to create an Airflow
airflow.lineage.entities.Table
( which is then converted to an OpenLineage Dataset ).It would be good if users could create OpenLineage Dataset classes directly in their DAGs with no special conversion necessary.
Solution
This extends the current implementation to simply pass through Datasets which are specified in inlets or outlets without modification.
In addition it makes the BashOperatorExtractor behave more similarly to the PythonOperator when source code collection is disabled which allows it to work with the manual lineage collection feature.
Checklist