Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tqdm logging in dbt-ol. #1549

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Adjust tqdm logging in dbt-ol. #1549

merged 1 commit into from
Feb 1, 2023

Conversation

JDarDagran
Copy link
Contributor

Signed-off-by: Jakub Dardzinski [email protected]

Fix ruff issues in gcs extractor.

Signed-off-by: Jakub Dardzinski [email protected]

Run integration-common unit tests when modyfing integration-dbt.

Signed-off-by: Jakub Dardzinski [email protected]

Problem

dbt-ol logged wrong number of events emitted with tqdm. Also it did not emit START event for parent run.

Closes: #1481

Solution

Emit start event. Adjust tqdm to show correct number of iterations.

Checklist

  • You've signed-off your work
  • Your pull request title follows our guidelines
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
  • You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

Signed-off-by: Jakub Dardzinski <[email protected]>

Fix ruff issues in gcs extractor.

Signed-off-by: Jakub Dardzinski <[email protected]>

Run integration-common unit tests when modyfing integration-dbt.

Signed-off-by: Jakub Dardzinski <[email protected]>
@JDarDagran JDarDagran merged commit 41801b7 into main Feb 1, 2023
@JDarDagran JDarDagran deleted the dbt/adjust-tqdm-logging branch February 1, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci CI area:integration/airflow openlineage-airflow area:integration/dbt openlineage-dbt area:tests Testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt-ol Logging the wrong number of events emitted
2 participants