flink: add metrics support #2633
Conversation
mobuchowski
force-pushed
the
flink-micrometer-metrics
branch
3 times, most recently
from
60e9485
to
9cf73e7
Compare
|
@mobuchowski Thanks for adding the metrics reporting functionality. Would you please add some context in README about how users should use and interpret the metrics? |
There was a problem hiding this comment.
Please provide description of this PR of what it adds and specify what metrics will be produced. This super helpful when trying to figure what was changed in the past by a PR.
Documentation PR is important as well:
- There is metrics section in Java client, however it is not linked from Spark integration. I think it should be included in both Spark and Flink integrations (include md partial)
- Additionally, I think it's important to provide info specific to Spark and Flink. As a Spark/Flink user I would like to know which metrics are emitted just to know if this is going to solve the problem I have or not.
| "https://github.com/OpenLineage/OpenLineage/tree/%s/integration/flink", getVersion())); | ||
| } | ||
|
|
||
| @SuppressWarnings("PMD") |
There was a problem hiding this comment.
Please mention particular warning you want to suppress.
There was a problem hiding this comment.
@pawel-big-lebowski to be honest, I've copied this fragment from Spark integration. Should I change this there as well?
There was a problem hiding this comment.
It's still in some places for Spark. However, in most places we're just suppressing a rule that is found problematic like:
@SuppressWarnings("PMD.AvoidCatchingNPE")
It's a better approach I think.
Signed-off-by: Maciej Obuchowski <[email protected]>
mobuchowski
force-pushed
the
flink-micrometer-metrics
branch
from
9cf73e7
to
3567f70
Compare
Signed-off-by: Maciej Obuchowski <[email protected]>
This adds support for #2496 metrics for Flink integration.