Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce rector to perform better laravel upgrades #657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

comes
Copy link

@comes comes commented Oct 5, 2024

I suggest using rector for upgrades to support this project and modernize the code base.

This PR provides a rector dependency and a very basic configuration. It also does some minor upgrades to the code base that are part of the upgrade guidelines when upgrading to laravel 11.

To learn more about rector, see rector.org

To run rector, you need to run ./vendor/bin/rector.

This PR is one of many to improve the OpenLitterMap code base and modernize it for a brighter future regarding readability and scalability.

All the best @xlcrr

Jeremias

@xlcrr
Copy link
Member

xlcrr commented Oct 6, 2024

Thanks @comes its been on my todo list for a while, I'm happy with 90% of this but it breaks a little bit of my coding style for better readability and don't have the time to dig into new rules at the moment. I'm focused on a few other things at the moment, ill come back to this when I can

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants