Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all CLI defaults #548

Merged
merged 12 commits into from
Oct 7, 2024
Merged

Document all CLI defaults #548

merged 12 commits into from
Oct 7, 2024

Conversation

xjjiang
Copy link
Contributor

@xjjiang xjjiang commented Sep 27, 2024

Summary

This PR checks and documents all the options of different aviary command work as expected.

For run_mission, option --n2 does not have effect on the output. It is removed.

For plot_drag_polar, it does not work at all. It needs a separate PR. A new issue #547 is created.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@xjjiang xjjiang marked this pull request as draft September 27, 2024 00:26
@xjjiang xjjiang marked this pull request as ready for review September 30, 2024 21:55
Copy link
Contributor

@crecine crecine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor suggestions throughout, but changes requested regarding the n2 flag

aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/docs/user_guide/aviary_commands.ipynb Outdated Show resolved Hide resolved
aviary/interface/methods_for_level1.py Outdated Show resolved Hide resolved
@crecine crecine enabled auto-merge October 7, 2024 21:47
@crecine crecine added this pull request to the merge queue Oct 7, 2024
Merged via the queue into OpenMDAO:main with commit fdc0a27 Oct 7, 2024
6 checks passed
@xjjiang xjjiang deleted the CLI_defaults branch October 8, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document defaults for CLI arguments
3 participants