Updated phase.load_case so that it uses the state_xxx_vals API. Specify parent when subproblems are used. #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than just set_val
…ut need to test for om version still
…ns less than 3.34.3
…ob can be more easily accessed. Added checks for duplicate problem names when creating a simulation problem, since OpenMDAO forbids duplicate problem names.
robfalck
changed the title
…can still occur, as can happen in testing.
kaushikponnapalli
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For later version of OpenMDAO, explicit simulation subproblems have their parent set to the trajectory or phase being simulated so that their output files show up nested under the parent problems output directory.
phase.load_casewas not using the new API for setting times, states, controls, and parameters.As a result, under Birkhoff, setting state values would only set the values in the segment polynomial, but not the end point values (
initial_states:{name}andfinal-states:{name}).Related Issues
phase.load_caseshould use the newphase.set_xxx_valsAPI #1086Backwards incompatibilities
None
New Dependencies
None