Reduced the memory allocation in the TimeseriesOutputComp in common use cases. #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… matrices. This is especially important in the Birkhoff transcription where the pseudospectral differentiation matrix is large and dense. In cases where the component was simply echoing its inputs as outputs, the interpolation matrix is not needed. If no rate outputs are needed, then the differentiation matrix is not needed. In light of the Birkhoff transcription, problems should be formulated to remove the need for differentiation matrices.
…eries_memory_fix
kaushikponnapalli
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TimeseriesOutputComp was allocating interpolation and differentiation matrices even when they were not used.
This PR refactors the configuration of TimeseriesOutputComp so that it does not bother constructing or saving the interpolation and or differentiation matrices when they are not used.
The
lagrange_matricesfunction now takescompute_Landcompute_Das boolean arguments, and will only construct the interpolation and/or differentiation matrices when requested.Related Issues
Backwards incompatibilities
None
New Dependencies
None