bokeh timeseries plots now comply with OpenMDAO's placement of recorder files. #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…record files in the problem outputs directory. Handle older OpenMDAO versions.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Added clean_notebooks script for quicly cleaning outputs from all notebooks.
…ion() in tests to handle older versions.
robfalck
commented
Aug 23, 2024
| @@ -31,7 +31,7 @@ jobs: | |||
| SCIPY: '1.13' | |||
| PETSc: '3.19' | |||
| PYOPTSPARSE: 'v2.11.0' | |||
| OPENMDAO: 'latest' | |||
| OPENMDAO: 'dev' | |||
There was a problem hiding this comment.
Changed to dev to avoid backwards compatibility code in the documentation.
robfalck
commented
Aug 23, 2024
| description: Verifies that documentation notebooks contain no output cells. | ||
| language: python | ||
| pass_filenames: false | ||
| entry: python ./docs/clean_notebooks.py --dryrun ./docs |
There was a problem hiding this comment.
Added to prevent accidentally commit of unclean notebooks.
robfalck
commented
Aug 23, 2024
| @@ -253,3 +255,26 @@ def create_subprob(base_name, comm, reports=False): | |||
| str_hash = hashlib.sha256(used_for_security=False)[:8] | |||
| p = om.Problem(comm=comm, reports=reports, name=f'{sim_prob_name}_{str_hash}') | |||
| return p | |||
|
|
|||
|
|
|||
| def om_version(): | |||
There was a problem hiding this comment.
Removes a lot of duplicate code of converting OpenMDAO version to tuple for comparison.
robfalck
commented
Aug 23, 2024
| [tool.ruff.lint.pycodestyle] | ||
| max-line-length = 100 | ||
| max-line-length = 130 |
There was a problem hiding this comment.
Consistent with pycodestyle settings.
Still need some work to implement pycodestyle checks.
swryan
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The latest OpenMDAO change puts recorder files in the problem outputs directory by default. This change makes dymos' timeseries plots handle that correctly.
Related Issues
Backwards incompatibilities
None
New Dependencies
None