Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cart-pole example #808

Merged
merged 13 commits into from
Aug 23, 2022
Merged

Added cart-pole example #808

merged 13 commits into from
Aug 23, 2022

Conversation

kanekosh
Copy link
Contributor

Summary

This PR adds a cart-pole example to the docs. I also added two corresponding tests:

  1. Test that checks the cart-pole ODE model and its partials.
  2. Test that checks the cart-pole optimization result.

Related Issues

None

Backwards incompatibilities

None

New Dependencies

None

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kanekosh kanekosh marked this pull request as ready for review August 18, 2022 20:50
@kanekosh kanekosh marked this pull request as draft August 18, 2022 21:19
@robfalck
Copy link
Contributor

Looks like you need an __init__.py in the dymos/examples/cart_pole directory so it gets installed as a part of the package.

@kanekosh
Copy link
Contributor Author

I forgot to commit __init__... Now it should be able to pass all the tests and docs build check.

@kanekosh kanekosh marked this pull request as ready for review August 18, 2022 22:39
@coveralls
Copy link

coveralls commented Aug 18, 2022

Coverage Status

Coverage decreased (-0.3%) to 95.215% when pulling 6f80eeb on kanekosh:cartpole_docs into 425becc on OpenMDAO:master.

@bernardopacini
Copy link
Contributor

Sorry for messing up the history here -- I went through and signed all of the commits to conform to the OpenMDAO standard.

@kanekosh
Copy link
Contributor Author

The docs build failed last time because we were using SNOPT in the embedded code. Now we use IPOPT instead so that it can pass the docs build check.

@robfalck
Copy link
Contributor

There's a few stale file changes in here. Everything is good except the history is a bit messed up.

Please run this from your cartpole_docs branch to see if we can resolve the unrelated changes:

git remote add upstream https://github.com/OpenMDAO/dymos  # If you don't already have upstream as a remote
git pull upstream master
git push origin cartpole_docs

@bernardopacini
Copy link
Contributor

I am not sure I got that to work as intended. I'll keep debugging this to clean it up.

@robfalck
Copy link
Contributor

Seems to have worked. There were some other files updated recently (load_case.py and the workflow yml files) that are no longer showing up as changed. Should be good now.

@bernardopacini
Copy link
Contributor

Seems to have worked. There were some other files updated recently (load_case.py and the workflow yml files) that are no longer showing up as changed. Should be good now.

I cleaned it up a bit further by dropping some commits that are already on master that would be duplicate. It should be set now, though let me know if you see any issues.

@robfalck robfalck merged commit 5b4287a into OpenMDAO:master Aug 23, 2022
@kanekosh kanekosh deleted the cartpole_docs branch October 3, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants