Refactored time_extents away in favor of housing extents in param_comp #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial_val, and t_duration val in param_comp
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Kenneth-T-Moore
approved these changes
Jul 18, 2023
| @@ -131,8 +126,8 @@ def configure_time(self, phase): | |||
| if not time_options['input_duration'] and not self._implicit_duration: | |||
| indeps.append('t_duration') | |||
|
|
|||
| for var in indeps: | |||
| phase.time_extents.add_output(var, val=default_vals[var], units=time_units) | |||
| # for var in indeps: | |||
There was a problem hiding this comment.
I think you can just delete these lines.
…hanged. Made test for parameter connections more specific to avoid picking up t_initial and t_duration.
…m t_duration_val. Included model_data.dat in the package data for the linkage report test.
robfalck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In support of upcoming changes, it made sense to treat
t_initialandt_durationas parameters that are always present in the ParameterComp. This change is mostly invisible to the user with a single backwards compatibility issue noted below.Related Issues
Backwards incompatibilities
t_initialandt_durationare now inputs to the phase and cannot be connected to other targets (other than via promotion.)Their values are available as outputs through
t_initial_valandt_duration_val.New Dependencies