Fixed some issues that were causing simulation to fail under MPI. #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions problematic.
simulation was failing under MPI. - Setting simulation phase values from their source phases now accounts for MPI. - This code is built on the assumption that a phase and its corresponding simulation phase are on the same processor. - The trajectory created by `Trajectory.simulate` will not bother setting up linkages or interphase connections since they are irrelevant for simulation. - Bumped the minimum OpenMDAO version as specified in setup.py to 3.26. We were already using this as the oldest supported version on CI. - In `set_vals_from_phase` for simulation phase we now don't grab variable values from their ultimate source (from_src=False). - The finite burn MPI test cases now include simulation.
dymos/trajectory/trajectory.py
Outdated
| @@ -1397,6 +1407,9 @@ def simulate(self, times_per_seg=10, method=_unspecified, atol=_unspecified, rto | |||
| """ | |||
| sim_traj = Trajectory(sim_mode=True) | |||
|
|
|||
| # self.phases.nonlinear_solver = om.NonlinearBlockJac() | |||
There was a problem hiding this comment.
Probably clean up these commented out lines.
Kenneth-T-Moore
approved these changes
Sep 1, 2023
…ication by time units. This prevents units such as '1/s*s' intead of None. Added a warnings context to simulation setup to ignore setup and unused options warnings that are not the fault of the user.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ither states or initial_states in the phase being simulated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed some issues that were causing simulation to fail under MPI.
Trajectory.simulatewill not bother setting up linkages or interphase connections since they are irrelevant for simulation.set_vals_from_phasefor simulation phase we now don't grab variable values from their ultimate source (from_src=False).Related Issues
Backwards incompatibilities
None
New Dependencies
None