Added linear solver for cases where states solved via optimizer have input_initial=True
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en input_initial=True for one or more states.
Kenneth-T-Moore
approved these changes
Sep 13, 2023
| @@ -513,8 +514,6 @@ def configure_solvers(self, phase): | |||
| newton.options['stall_limit'] = 3 | |||
| newton.linesearch = om.BoundsEnforceLS() | |||
|
|
|||
| # even though you don't need a nl_solver for connections, you still ln_solver since its implicit | |||
| if self.any_solved_segs or self._implicit_duration: | |||
There was a problem hiding this comment.
Should the next 2 lines be de-dented?
There was a problem hiding this comment.
Oh, didn't notice the line cut. This is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a linear solver directly to the StateIndependentsComp in such cases, since having it apply to the entire phase is generally overkill here.
Related Issues
Backwards incompatibilities
None
New Dependencies
None