docker: refactor manylinux Dockerfile #137
Conversation
| python-devel \ | ||
| qt5-qtsvg \ | ||
| libtool \ | ||
| cmake3 | ||
| # RUN yum install -y libsvm-devel glpk-devel libzip-devel zlib-devel xerces-c-devel bzip2-devel sqlite-devel hdf5-devel |
There was a problem hiding this comment.
Yes, apparently we tried that before.
Until recently CoinOR (fixed) and Wildmagick (removed) were problems.
We can try CoinOR from yum if we find it.
| # TODO: do we need sqlite-devel? | ||
| # TODO: can we install boost from yum? | ||
| # TODO: is coin-or-CoinUtils-devel useful? | ||
| # TODO: do we need KissFFT? It's not installed in the regular contrib Dockerfile |
There was a problem hiding this comment.
@jpfeuffer I think we don't need KissFFT right?
| RUN cmake -DBUILD_TYPE=ALL ../contrib && rm -rf archives src | ||
|
|
||
| WORKDIR ${CONTRIB_BUILD_DIR} | ||
| RUN cmake -DBUILD_TYPE="BOOST;COINOR;KISSFFT;OPENMP" ../contrib && rm -rf archives src |
There was a problem hiding this comment.
this currently doesn't work because our IT is down (again)
There was a problem hiding this comment.
On Linux you probably don't need contrib.
I guess even centos7 has everything we need.
There was a problem hiding this comment.
that would simplify things a lot
There was a problem hiding this comment.
I was too quick. Should have known that CoinOR is basically available nowhere..
There was a problem hiding this comment.
yes, IIRC this was one of the blockers of using yum for everything
| qt5-qtsvg-devel \ | ||
| eigen3-devel \ | ||
| python-devel | ||
| # TODO: do we need sqlite-devel? |
There was a problem hiding this comment.
Yes. It is probably a dependency of something
| eigen3-devel \ | ||
| python-devel | ||
| # TODO: do we need sqlite-devel? | ||
| # TODO: can we install boost from yum? |
| python-devel | ||
| # TODO: do we need sqlite-devel? | ||
| # TODO: can we install boost from yum? | ||
| # TODO: is coin-or-CoinUtils-devel useful? |
There was a problem hiding this comment.
Yes but probably a dependency of other CoinOR libs
| cmake3 \ | ||
| # OpenMS and PyOpenMS build dependencies | ||
| libsvm-devel \ | ||
| glpk-devel \ |
There was a problem hiding this comment.
Avoid, if it works with coinor
|
@radusuciu I hope I am not asking for too much, but can you try if we can get away with just the yum packages? |
Not asking for too much, that was my goal! I had some issues though but will need to take another pass after taking a look at your comments. I might not have time to do this right away but will comment back when I do. |
Submitting as draft because it's not currently building, though I think it's related to the build server being down.
Can we, like we did for the other
Dockerfile, instead install more of the packages fromyum?