Addresses Incorrect stock versus sales. #364

This is a possible solution to fixing the incorrect stock when under high load, high concurrency on a single item and slow payment gateways.
OpenMage · Nov 14, 2017 · 88c4e0a · 88c4e0a
1 parent c760e36
commit 88c4e0a
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 4 deletions.
diff --git a/app/code/core/Mage/CatalogInventory/Model/Observer.php b/app/code/core/Mage/CatalogInventory/Model/Observer.php
@@ -744,7 +744,7 @@ public function reindexQuoteInventory($observer)
         // Reindex previously remembered items
         $productIds = array();
         foreach ($this->_itemsForReindex as $item) {
-            $item->save();
+            $item->updateStockStatus();
             $productIds[] = $item->getProductId();
         }
         Mage::getResourceSingleton('catalog/product_indexer_price')->reindexProductIds($productIds);

diff --git a/app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item.php b/app/code/core/Mage/CatalogInventory/Model/Resource/Stock/Item.php
@@ -126,4 +126,22 @@ protected function _prepareDataForTable(Varien_Object $object, $table)
         }
         return $data;
     }
+
+    /**
+     * Update specific fields of a single row.
+     *
+     * @param int $itemId Item id of the row being updated
+     * @param mixed[] $data Array structure of fields being updated
+     *
+     * @return $this
+     */
+    public function updateRecord($itemId, $data)
+    {
+        $adapter = $this->_getWriteAdapter();
+
+        $where = array('item_id = ?' => $itemId);
+
+        $adapter->update($this->getMainTable(), $data, $where);
+        return $this;
+    }
 }
diff --git a/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php b/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php
@@ -392,7 +392,7 @@ public function getQtyIncrements()
         return $this->_qtyIncrements;
     }
 
-     /**
+    /**
      * Retrieve Default Quantity Increments data wrapper
      *
      * @deprecated since 1.7.0.0
@@ -556,8 +556,8 @@ public function checkQuoteItemQty($qty, $summaryQty, $origQty = 0)
             $qty = intval($qty);
 
             /**
-              * Adding stock data to quote item
-              */
+             * Adding stock data to quote item
+             */
             $result->setItemQty($qty);
 
             if (!is_numeric($qty)) {
@@ -767,6 +767,41 @@ protected function _beforeSave()
         return $this;
     }
 
+    /**
+     * Update Stock Status and low stock date as if $this->save() has been
+     * called, keeping the update query very light, by only touching those
+     * fields of interest
+     *
+     * @return $this
+     */
+    public function updateStockStatus()
+    {
+        $this->setOrigData()->setDataChanges(false);
+        $this->_beforeSave();
+
+        if ($this->hasDataChanges()) {
+
+            $updatedFields = array(
+                'is_in_stock' => $this->getIsInStock(),
+                'stock_status_changed_auto' => $this->getStockStatusChangedAutomatically(),
+                'low_stock_date' => $this->getLowStockDate()
+            );
+
+            $this->getResource()
+                ->updateRecord($this->getId(), $updatedFields);
+
+            Mage::dispatchEvent(
+                'cataloginventory_stock_item_save_after',
+                array(
+                    'item' => $this,
+                    'data_object' => $this,
+                )
+            );
+        }
+
+        return $this;
+    }
+
     /**
      * Chceck if item should be in stock or out of stock based on $qty param of existing item qty
      *