-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OpenMage : custom theme not work (solved) #1796
Comments
Hi, |
Maybe I have the temporary solution, go into categories and assign the custom style to the root category (or desired categories) |
Here we go again, same problem upgrade from 20.0.12 to 20.0.13 custom fears does not work, you lose the css. Can you check for this bug that occurs every single time you update openmage? the custom theme and a variant of rwd (Mimic) where there are only the files indicated in the repositories (still under control) present in OpenMage theme. this time I also created a completely new thema folder independent of rwd, result: it doesn't work |
Hello I read a little about the reasons for these changes. I would like to specify that with no browser the css file of the customized theme is loaded the custom theme is a direct descendant of RWD apart from the css file and a few modifications of some files that do not affect the classes in any way. the result is that themes other than rwd are not loaded. it's a huge problem ps: the problem recurs also with the 20.0.13 version of openmage |
I am interested in investigating this issue but I need to describe in detail all the your steps in reproducing it after installing from scratch OpenMage 20.0.13, including any modification in website settings. I'm sorry to comment, but the way you reported this issue is incomplete, even vaguely. |
thank you for your interest. I use google translate. I apologize for any communication difficulties. it's been a few months so I'll tell the installation by heart I created a server: ubuntu 20.04 i have the following installation path of the websites / var / www / openmage is installed in the subdirectori / var / www / openmage I transferred the openmage source to the openmage folder. as the composer installs openmage in a subdirectory with assigned name I had to copy the composer.json file in the "www" directory script of composer.json: I assigned a "magento" user with read-write permissions to the openmage folder and the composer.json file via ssh as user "magento" I started the command "composer update" Composer ran its processes without errors by installing OpenMage 20.0.8 , all this to be able to upgrade OpenMage without errors via Composer in the future. about 2 weeks ago I updated magento from 20.0.8 to 20.0.12 via "composer update" command, composer performed everything without errors. since that moment the custom template has not worked anymore the template can be found here: I have brought OpenMage back to version 20.0.8 with a backup file and it worked I tried 2 days ago to update OpenMage to version 20.0.13 but it has the same problem as 20.0.12 that's all I remember doing. ps: my server does a redis and cache cleanup every night, the error shows up after the "server restart" |
The fact that you use Google Translate should not have been a problem in reporting all the steps you followed in reproducing the issue. Unfortunately, you did not provide me with the information I wanted. Here is how I tried to reproduce the problem you reported initially:
OpenMage 20.0.8: I did not identify any issues |
After investigating in more detail I came to the conclusion that the Mimic theme uses layout files that have not been updated with the latest RWD version which has changes in 20.0.11. If the /app/design/frontend/rwd/mimic/layout/page.xml file is renamed then the one in /app/design/frontend/rwd/default/layout/page.xml will be used and the CSS files are loaded. In this way the page doesn't have any issues with the layout. You can see below the proof that once the XML file name was changed, the styles.css file from mimic directory was loaded. In conclusion, this issue report is not coming from OpenMage code but in the theme files used. Therefore it can be closed. In the future those who report issues please perform tests to allow us to start from a level not from the ground. |
thank you all for the inquiry and time commitment.
I will modify Mimic to make it compatible. on this occasion I will write a
small tutorial for those who in the future have a custom thema based on RWD
prior to 20.0.8
Il dom 5 set 2021, 19:41 ADDISON ***@***.***> ha scritto:
… After investigating in more detail I came to the conclusion that the Mimic
theme uses layout files that have not been updated with the latest RWD
version which has changes in 20.0.11.
If the /app/design/frontend/rwd/mimic/layout/page.xml file is renamed then
the one in /app/design/frontend/rwd/default/layout/page.xml will be used
and the CSS files are loaded. In this way the page doesn't have any issues
with the layout. You can see below the proof that once the XML file name
was changed, the styles.css file from mimic directory was loaded.
[image: mimic]
<https://user-images.githubusercontent.com/8360474/132136166-407c0fda-197f-4a28-80b7-1a0a24cbfa93.jpg>
In conclusion, this issue report is not coming from OpenMage code but in
the theme files used. Therefore it can be closed. Please in the future that
those who report issues to perform tests to allow us to start from a level
not from the ground.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1796 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALCKSZVLH47GPBQWUTLKJ4DUAOTU7ANCNFSM5CP3E6DA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
the solution you suggest is applicable only and exclusively if the custom theme is limited to being nested in RWD. If a user wants to create a separate Theme folder from RWD the problem persists. If there is a guideline informing web designers how to modify templates prior to opemage version 20.0.11 please leave the link. Thanks. (ps:To try to understand, I compared the page.xml files of mici and rwd. The only difference is in line 69 which I have changed. the result does not change. People have different levels of proficiency, there are people who bought their own temlate with Magento 1. Others (like me) build it using the original theme as a basis because they know how to use css and a bit of html others like you (fortunately) know how to do much more. this is to say that I would have liked to offer you a easier starting point, but not everyone can do it. |
Resolved I cloned the RWD certella both in app / design / and in Skin / frontend I changed the RWD name to the custom template name I then copied the custom theme files without selecting the files: /app/design/frontend/tema-custom/etc/theme.xml And /app/design/frontend/tema-custom/layout/page.xml now works |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: