A lot of exceptions after login in backend #3625

empiricompany · 2023-11-01T09:32:13Z

Reference PR:

The bug was introduced by this PR in loadRules(): an exception was added instead of this.
https://github.com/OpenMage/magento-lts/pull/2339/files#diff-1048571d4baf38d246708d5953af464948b5591c2c8d648036394d6101ba8022

Possible solution

Rollback and remove Mage::logException($e); in app/code/core/Mage/Admin/Model/Resource/Acl.php::loadRules()
I also recommend including the commented TODO code because it would be a feature to implement (the deletion of old resources),
that was this:

//$m = $e->getMessage();
//if ( eregi("^Resource '(.*)' not found", $m) ) {
    // Deleting non existent resource rule from rules table
    //$cond = $this->_write->quoteInto('resource_id = ?', $resource);
    //$this->_write->delete(Mage::getSingleton('core/resource')->getTableName('admin/rule'), $cond);
//} else {
    //TODO: We need to log such exceptions to somewhere like a system/errors.log
//}

in Mage_Admin_Model_Resource_Acl::loadRules() was added an exception

Preconditions (*)

Install OpenMage 20.2.0 - PHP 7.4 - MySQL 5.7
Install an extension that adds some resources to the admin_rule table (seems like the issue only occurs with deny permission resources).
Disable the previously installed extension from app/etc/modules/Vendor_Extension.xml.

Steps to reproduce (*)

Login to the admin area.

Expected result (*)

No exceptions should be logged for resources with deny permission.

Actual result (*)

All resources with deny permission referring to the disabled extension have been logged with exceptions:

2023-11-01T08:44:04+00:00 ERR (3):
Zend_Acl_Exception: Resource 'admin/mageplaza_betterblog/new/action' not found in /var/www/html/htdocs/vendor/shardj/zf1-future/library/Zend/Acl.php:365
Stack trace:
#0 /var/www/html/htdocs/vendor/shardj/zf1-future/library/Zend/Acl.php(641): Zend_Acl->get()
#1 /var/www/html/htdocs/vendor/shardj/zf1-future/library/Zend/Acl.php(519): Zend_Acl->setRule()
#2 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Resource/Acl.php(132): Zend_Acl->deny()
#3 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Resource/Acl.php(70): Mage_Admin_Model_Resource_Acl->loadRules()
#4 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Session.php(162): Mage_Admin_Model_Resource_Acl->loadAcl()
#5 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Observer.php(62): Mage_Admin_Model_Session->login()
#6 /var/www/html/htdocs/app/code/core/Mage/Core/Model/App.php(1448): Mage_Admin_Model_Observer->actionPreDispatchAdmin()
#7 /var/www/html/htdocs/app/code/core/Mage/Core/Model/App.php(1426): Mage_Core_Model_App->_callObserverMethod()
#8 /var/www/html/htdocs/app/Mage.php(509): Mage_Core_Model_App->dispatchEvent()
#9 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Action.php(527): Mage::dispatchEvent()
#10 /var/www/html/htdocs/app/code/core/Mage/Adminhtml/Controller/Action.php(173): Mage_Core_Controller_Varien_Action->preDispatch()
#11 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Action.php(410): Mage_Adminhtml_Controller_Action->preDispatch()
#12 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(255): Mage_Core_Controller_Varien_Action->dispatch()
#13 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Front.php(181): Mage_Core_Controller_Varien_Router_Standard->match()
#14 /var/www/html/htdocs/app/code/core/Mage/Core/Model/App.php(358): Mage_Core_Controller_Varien_Front->dispatch()
#15 /var/www/html/htdocs/app/Mage.php(743): Mage_Core_Model_App->run()
#16 /var/www/html/htdocs/index.php(65): Mage::run()
#17 {main}

It seems that this issue also occurs for old deprecated resources (my installation was updated from Magento 1.9.4.5) such as:

2023-11-01T08:44:04+00:00 ERR (3):
Zend_Acl_Exception: Resource 'admin/system/api/consumer/edit' not found in /var/www/html/htdocs/vendor/shardj/zf1-future/library/Zend/Acl.php:365
Stack trace:
#0 /var/www/html/htdocs/vendor/shardj/zf1-future/library/Zend/Acl.php(641): Zend_Acl->get()
#1 /var/www/html/htdocs/vendor/shardj/zf1-future/library/Zend/Acl.php(519): Zend_Acl->setRule()
#2 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Resource/Acl.php(132): Zend_Acl->deny()
#3 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Resource/Acl.php(70): Mage_Admin_Model_Resource_Acl->loadRules()
#4 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Session.php(162): Mage_Admin_Model_Resource_Acl->loadAcl()
#5 /var/www/html/htdocs/app/code/core/Mage/Admin/Model/Observer.php(62): Mage_Admin_Model_Session->login()
#6 /var/www/html/htdocs/app/code/core/Mage/Core/Model/App.php(1448): Mage_Admin_Model_Observer->actionPreDispatchAdmin()
#7 /var/www/html/htdocs/app/code/core/Mage/Core/Model/App.php(1426): Mage_Core_Model_App->_callObserverMethod()
#8 /var/www/html/htdocs/app/Mage.php(509): Mage_Core_Model_App->dispatchEvent()
#9 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Action.php(527): Mage::dispatchEvent()
#10 /var/www/html/htdocs/app/code/core/Mage/Adminhtml/Controller/Action.php(173): Mage_Core_Controller_Varien_Action->preDispatch()
#11 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Action.php(410): Mage_Adminhtml_Controller_Action->preDispatch()
#12 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(255): Mage_Core_Controller_Varien_Action->dispatch()
#13 /var/www/html/htdocs/app/code/core/Mage/Core/Controller/Varien/Front.php(181): Mage_Core_Controller_Varien_Router_Standard->match()
#14 /var/www/html/htdocs/app/code/core/Mage/Core/Model/App.php(358): Mage_Core_Controller_Varien_Front->dispatch()
#15 /var/www/html/htdocs/app/Mage.php(743): Mage_Core_Model_App->run()
#16 /var/www/html/htdocs/index.php(65): Mage::run()
#17 {main}

The text was updated successfully, but these errors were encountered:

m-overlund · 2023-11-01T14:00:33Z

can confirm - having the same issues.

addison74 · 2023-11-01T14:16:17Z

@sreichel - Could you please check? This report refers to a PR created by you and we honestly appreciate your feedback.

empiricompany · 2023-11-01T14:35:20Z

Here too, exceptions have been introduced that were not there before.

app/code/core/Mage/Customer/Block/Widget/Dob.php
https://github.com/OpenMage/magento-lts/pull/2339/files#diff-ff8282545e24b059dad91672ee2832850596a81f99cf384335a8442f57d5990e
app/code/core/Mage/Api/Model/Session.php
https://github.com/OpenMage/magento-lts/pull/2339/files#diff-02f821d60c42627253d564f7f7a434c94f9c2c26969231306048bdbb27a4dc13

addison74 · 2023-11-01T14:50:38Z

If it turns out to be a wrong change then I propose to revert PR #2339.

sreichel · 2023-11-01T18:00:17Z

@sreichel - Could you please check? This report refers to a PR created by you and we honestly appreciate your feedback.

Imho it's okay to log it. Just need to add documentation how to remove that orphan entries.

#2339 (comment)

empiricompany · 2023-11-02T07:39:48Z

@sreichel - Could you please check? This report refers to a PR created by you and we honestly appreciate your feedback.

Imho it's okay to log it. Just need to add documentation how to remove that orphan entries.

#2339 (comment)

It's okay if there is a method to clean the database; otherwise, it just unnecessarily fills up the logs.
I propose removing all the added logException calls from the PR.

Sdfendor · 2023-11-02T13:30:05Z

@sreichel - Could you please check? This report refers to a PR created by you and we honestly appreciate your feedback.

Imho it's okay to log it. Just need to add documentation how to remove that orphan entries.
#2339 (comment)

It's okay if there is a method to clean the database; otherwise, it just unnecessarily fills up the logs. I propose removing all the added logException calls from the PR.

I (the team I'm working in) actually really like this change. By that we found a lot of orphans in our DB we could clean up. A script would be nice though. What's the purpose of such exceptions, if higher up they just get ignored (the previous state)? The database fills (slowly) with garbage data and nobody notices it.

empiricompany · 2023-11-03T12:00:17Z

@sreichel - Could you please check? This report refers to a PR created by you and we honestly appreciate your feedback.

Imho it's okay to log it. Just need to add documentation how to remove that orphan entries.
#2339 (comment)

It's okay if there is a method to clean the database; otherwise, it just unnecessarily fills up the logs. I propose removing all the added logException calls from the PR.

I (the team I'm working in) actually really like this change. By that we found a lot of orphans in our DB we could clean up. A script would be nice though. What's the purpose of such exceptions, if higher up they just get ignored (the previous state)? The database fills (slowly) with garbage data and nobody notices it.

Yes, it would be necessary to implement a cleanup of old entries, but until we have it, it is necessary to remove the exception, otherwise, the exception log will grow.

sreichel · 2023-11-04T06:00:17Z

Yes, it would be necessary to implement a cleanup of old entries, but until we have it, it is necessary to remove the exception, otherwise, the exception log will grow.

The problem i see are the disabled extensions - how to detect them?

Just an idea ... if an unused acl is found ...

whitelist them in core_config_data (or somewhere else)
check whitelist before delete entries
log exeption / add an admin notification only once

Any better ideas?

empiricompany · 2023-11-04T07:30:52Z

Yes, it would be necessary to implement a cleanup of old entries, but until we have it, it is necessary to remove the exception, otherwise, the exception log will grow.

The problem i see are the disabled extensions - how to detect them?

Just an idea ... if an unused acl is found ...
* whitelist them in core_config_data (or somewhere else)

* check whitelist before delete entries

* log exeption / add an admin notification only once
Any better ideas?

The priority is to remove the logException ASAP.

The main issue is that I can temporarily disable an extension without having to necessarily perform a cleanup of ACL and other orphaned data in the database, including tables like core_resource and core_config_data. As a result, the removal and cleanup of this data should be done explicitly and cannot be automated.

kiatng · 2023-11-04T09:49:04Z

An idea is to add a menu "Manage Orphaned Resources" to render a grid with collection:

$collection = Mage::getResourceModel('admin/rules_collection')
    ->addFieldToFilter('resource_id', ['nin' => Mage::getModel('admin/roles')->getResourcesList2D()]);

And add a mass-action to delete the selected items.

loekvangool · 2023-11-08T11:21:18Z

It also sounds like a typical job for n98-magerun to remove orphaned ACL entries, just throwing it out there.

empiricompany added the bug label Nov 1, 2023

addison74 added needs investigation and removed bug labels Nov 1, 2023

empiricompany mentioned this issue Nov 10, 2023

Orphaned ACL resource exceptions are now logged only in developer mode #3642

Merged

4 tasks

kiatng mentioned this issue Nov 12, 2023

New feature: UI to list and remove orphaned ACL resources in backend. #3647

Merged

fballiano closed this as completed in #3642 Nov 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A lot of exceptions after login in backend #3625

A lot of exceptions after login in backend #3625

empiricompany commented Nov 1, 2023

m-overlund commented Nov 1, 2023

addison74 commented Nov 1, 2023

empiricompany commented Nov 1, 2023 •

edited

Loading

addison74 commented Nov 1, 2023

sreichel commented Nov 1, 2023 •

edited

Loading

empiricompany commented Nov 2, 2023

Sdfendor commented Nov 2, 2023 •

edited

Loading

empiricompany commented Nov 3, 2023

sreichel commented Nov 4, 2023 •

edited

Loading

empiricompany commented Nov 4, 2023

kiatng commented Nov 4, 2023

loekvangool commented Nov 8, 2023 •

edited

Loading

A lot of exceptions after login in backend #3625

A lot of exceptions after login in backend #3625

Comments

empiricompany commented Nov 1, 2023

Reference PR:

Possible solution

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m-overlund commented Nov 1, 2023

addison74 commented Nov 1, 2023

empiricompany commented Nov 1, 2023 • edited Loading

addison74 commented Nov 1, 2023

sreichel commented Nov 1, 2023 • edited Loading

empiricompany commented Nov 2, 2023

Sdfendor commented Nov 2, 2023 • edited Loading

empiricompany commented Nov 3, 2023

sreichel commented Nov 4, 2023 • edited Loading

empiricompany commented Nov 4, 2023

kiatng commented Nov 4, 2023

loekvangool commented Nov 8, 2023 • edited Loading

empiricompany commented Nov 1, 2023 •

edited

Loading

sreichel commented Nov 1, 2023 •

edited

Loading

Sdfendor commented Nov 2, 2023 •

edited

Loading

sreichel commented Nov 4, 2023 •

edited

Loading

loekvangool commented Nov 8, 2023 •

edited

Loading