New feature: UI to list and remove orphaned ACL resources in backend.

[kiatng]

Description (*)

Orphaned ACL resources are left behind in the admin_rule table when modules are removed. This PR provides a UI to list these orphaned resources and delete them in backend > System > Permissions > Orphaned Resources.

Related Pull Requests

See PR #2339 that log the orphaned resources.
See PR #3642 that revert #2339 to not cluttered exception.log.

Fixed Issues (if relevant)

1. Fixes A lot of exceptions after login in backend  #3625

Screenshots [edited]

At backend login:

Grid to list and delete:

[sreichel]

Nice. Just did a visual review ... whats about disabled extensions?

(thats why ive not completed commented code parts)

[sreichel]

Add strict types for new classes?

[fballiano]

I think a n98-magerun action or a shell script would be enough because it's a one time maintainance thing, but good job anyway!

[luigifab]

@sreichel do you think that there are a lot of work with find app/ shell/ lib/Mage/ lib/Magento/ lib/Varien/ -name "*.ph*" -type f -exec sed -i '1s/<?php/<?php declare(strict_types=1);/' {} + ? (chatgpt powered)

💣

Edit: .... ~10 files to edit for backend! But, I didn't tested all pages.
loool: var_dump(Mage::app()->getStore()->getId()); => string(1) "0"

[empiricompany]

Good job, but it would appear in all my clients' dashboards who are not developers and wouldn't know what to do.
I agree with @fballiano that for these developer-related tasks, it is better to provide a utility in a shell script or n98-magerun.

Question: I haven't tested it yet, but what happens if I remove the permissions of a temporarily disabled extension? Will they be automatically recreated or will break the extension ?

Unfortunately, there is no system for uninstalling extensions. There are other things to consider, such as cleaning up the core_resource and core_config tables, and rolling back any database changes.
IMHO, I still believe it is better to remove the exception. Otherwise, every time I remove/disable an extension, the problem reoccurs.

[fballiano]

just some quick last minute formal fixes and I'll absolutely approve this

[addison74]

All the other links in the menu are limited to one word. If we rename the new link just "Resources", is it a bad idea? In my opinion no, because it covers everything related to resources.

[fballiano]

I kinda prefer more verbose names expecially if they're more understandable :-)

[fballiano]

another review and we're good to merge

[fballiano]

it would be so nice to have enough reviews for a new feature..

[addison74]

It works as described. Good job @kiatng.