Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not clear cache when there is no product id #44

Closed
tmotyl opened this issue Oct 5, 2015 · 2 comments
Closed

do not clear cache when there is no product id #44

tmotyl opened this issue Oct 5, 2015 · 2 comments
Labels
Component: Catalog Relates to Mage_Catalog performance Performance related

Comments

@tmotyl
Copy link
Contributor

tmotyl commented Oct 5, 2015

Magento calls cleanCache on before_save in product even if there is no product ID yet (product was just created).
This can lead to unnecessary cache clearing.

see
https://github.com/OpenMage/magento-lts/blob/1.9.2.1/app/code/core/Mage/Catalog/Model/Product.php#L618

the clean cache should be wrapped in
if ($this->getId()) {
}
@LeeSaferite
Copy link
Contributor

Could you submit a PR?

@tmotyl
Copy link
Contributor Author

tmotyl commented Oct 5, 2015

sure I will :)

tmotyl added a commit that referenced this issue Oct 8, 2015
@tmotyl
Do not clear product cache when saving new product
f9fa51a 
Resolves #44
@tmotyl tmotyl mentioned this issue Oct 8, 2015
Merged
Flyingmana pushed a commit to Flyingmana/magento-lts that referenced this issue Oct 18, 2016
@tmotyl @Flyingmana
Do not clear product cache when saving new product
01ca33a 
Resolves OpenMage#44
@tomekjordan tomekjordan mentioned this issue Feb 22, 2017
Closed
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Nov 27, 2017
@tmotyl @edannenberg
[impr#45] Do not clear product cache when saving a new product
8c421b0 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Dec 6, 2017
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
dc12341 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Feb 28, 2018
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
2aa775b 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Jul 17, 2018
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
53142e5 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Sep 19, 2018
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
52d8f1b 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Feb 14, 2019
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
02ec19c 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Apr 1, 2019
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
0ca70e9 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 22, 2019
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
5904778 
Resolves OpenMage#44
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Oct 25, 2019
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
bc89f2b 
Resolves OpenMage#44
@sreichel sreichel added Component: Catalog Relates to Mage_Catalog fixed performance Performance related labels Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this issue Aug 20, 2020
@tmotyl @edannenberg
[impr-OpenMage#45] Do not clear product cache when saving a new product
e226673 
Resolves OpenMage#44
randallelliott714 added a commit to randallelliott714/magento that referenced this issue Oct 18, 2022
@randallelliott714
Do not clear product cache when saving new product
bdc63bd 
Resolves OpenMage/magento-lts#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog performance Performance related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeeSaferite @tmotyl @sreichel