Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for installing on MySQL 8. Fixes #935 #1011

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix for installing on MySQL 8. Fixes #935 #1011

merged 1 commit into from
Jun 5, 2020

Conversation

colinmollenhour
Copy link
Member

As per discussion on #935 this fixes installation on MySQL 8.0.

Testing procedure:

  • Created fresh install using an empty MySQL 8 database
  • Loaded some frontend pages
  • Voted in poll
  • Logged into admin UI
  • Created a simple product
  • Created a subcategory of Default Category as anchor
  • Assigned product to new category and Default Category
  • Reindexed all indexes
  • Browsed frontend to new category and product pages
  • Added one item to cart and completed checkout
  • Created a fresh install using an empty MySQL 5.7 database to ensure no regressions

No issues found!

kiatng
kiatng approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this fix since January in a few new instances of OpenMage and have not encountered any problem too. Thanks for the PR.

@colinmollenhour colinmollenhour merged commit 6bd982b into OpenMage:1.9.4.x Jun 5, 2020
@sreichel sreichel added MySQL 8 Relates to MySQL8 bug enhancement labels Jun 5, 2020
sreichel
sreichel reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running MySql8 w/o problems 👍

@sreichel sreichel added Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien labels Jun 19, 2020
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@colinmollenhour @edannenberg
[bug-OpenMage#1011] Installation does not work with MySQL 8
a0b6790
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
@colinmollenhour @edannenberg
[bug-OpenMage#1011] Installation does not work with MySQL 8
53c151a
@cmuench cmuench mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel left review comments

@kiatng kiatng kiatng approved these changes

@sqlexception sqlexception Awaiting requested review from sqlexception

Assignees
No one assigned
Labels
bug Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien enhancement MySQL 8 Relates to MySQL8
Projects
None yet
Milestone
Release 19.4.4 / 20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@colinmollenhour @kiatng @sreichel