Correct name for Request class in Payment Module #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not touch it in #725 for this reason. I'd prefer to remove it .... |
There is already a class with name Mage_Paygate_Model_Authorizenet_Request in Paygate module. The class in Payment module was never used by autoloader so it's safe to remove it
|
I've changed th PR to remove the class. |
colinmollenhour
approved these changes
Jun 9, 2020
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…rizenet_Request There is already a class with name Mage_Paygate_Model_Authorizenet_Request in Paygate module.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
…rizenet_Request There is already a class with name Mage_Paygate_Model_Authorizenet_Request in Paygate module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a class with name
Mage_Paygate_Model_Authorizenet_Request
in Paygate module.
Alternatively we should just remove the class as it was never used (autoload couldnt reach it).
What's your opinion on that?