Clean review_entity_summary when reviews are deleted

[fballiano]

This PR should fix bug #1102

When deleting all reviews of an entity the review_entity_summary isn't cleaned correctly. I tried many different ways to approach the problem but the implemented one seems the easiest and most effective.

Also, the default implementation some of the methods of the Mage_Review modules seem incomplete, they lack the "entity_type" parameters which make the implementations prone to errors when different entities have the same PkValue.

[sreichel]

Tested yesterday and think this PR isn't complete ....

Can you please test again with ...

• reviews made in backend and frontend
• reviews with ratings (found some strange behavior here)

[fballiano]

sorry to come again on this after so long:

• tested reviews done in backend and the patch removes the review, the ratings and recalculates the aggregation, so I think it work for this case
• tested reviews done in frontend (although the review submit form wasn't showing, I had to change app/design/frontend/rwd/default/template/review/product/view/list.phtml to make it appear) and also here it seems that the patch works fine, removing the reviews, the ratings and recalculating the aggregations

Am I missing something?

[addison74]

I created 3 reviews in Frontend and approved them in Backend. In the database table review_entity_summary columns [reviews_count] and [rating_summary] have changed accordingly. In the Backend I changed the rating and in the table the percentage was recalculated correctly. Then I deleted the reviews one by one and also the changes in the table were correct. After I deleted the last review of the product in the table review_entity_summary there was no record for it, which is correct and the issue I reported initially is solved.

Then I created 3 reviews in Backend and I repeated the previous steps, I also didn't find anything wrong, and I didn't find any records in the logs.

If there are no objections to the code, my opinion this commit must be merged.

[addison74]

@fballiano: In table review_entity_summary for a product there are two rows. They differ only in the values on the store_id column, 0 (admin) and 1 (default). Do you know the reason why there is a row for admin?

[fballiano]

@fballiano: In table review_entity_summary for a product there are two rows. They differ only in the values on the store_id column, 0 (admin) and 1 (default). Do you know the reason why there is a row for admin?

no idea 😅

[fballiano]

Admins what can we do to move this forward?

[Flyingmana]

Getting some approving Reviews usually helps.
Shared the PR via twitter to increase its visibility.

[fballiano]

@addison74 I think you tested the fix, could you "approve" the PR with green button on https://github.com/OpenMage/magento-lts/pull/1103/files (and then select "approve")?

Thanks!

[addison74]

@fballiano - I tested it and I didn't find anything wrong, no errors, Your changes solve that initial issue.

Edit - I found the Approve button. Many thanks for pointing me out.

[luigifab]

array( Seems good. )

To clean up data: DELETE FROM review_entity_summary WHERE entity_pk_value NOT IN (SELECT entity_pk_value FROM review)