Removed redundant if statement

[Sekiphp]

Description (*)

In method addIdFilter is redundant if statement and some code is unreachable.

Look at pseudocode below (#3 is never executed because we evalueate if (empty($productId)) { above).

function addIdFilter($productId, $exclude = false)
{
    if (empty($productId)) {
        return "#1 (empty)";
    }
    if (is_array($productId)) {
        if (!empty($productId)) {
            return "#2 (not empty)";
        } else {
            return "#3 (empty)";
        }
    } else {
        return "#4 (not array)";
    }
}


var_dump(addIdFilter(123));             // string(14) "#4 (not array)"
var_dump(addIdFilter([123]));           // string(14) "#2 (not empty)"
var_dump(addIdFilter([0]));             // string(14) "#2 (not empty)"
var_dump(addIdFilter(0));               // string(10) "#1 (empty)"
var_dump(addIdFilter(null));            // string(10) "#1 (empty)"
var_dump(addIdFilter(""));              // string(10) "#1 (empty)"
var_dump(addIdFilter("567"));           // string(14) "#4 (not array)"
var_dump(addIdFilter([null]));          // string(14) "#2 (not empty)"
var_dump(addIdFilter(['']));            // string(14) "#2 (not empty)"
var_dump(addIdFilter(array()));         // string(10) "#1 (empty)"

Manual testing scenarios (*)

$collection = Mage::getModel('catalog/product')->getCollection()->addIdFilter([10, 20, 30]);
var_dump($collection->getColumnValues('sku'));

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[kiatng]

LGTM

[github-actions]

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit 96e8e90.