Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a word-break to list items to keep the layout intact #1321

Merged
merged 2 commits into from
May 19, 2022

Conversation

loekvangool
Copy link
Contributor

@loekvangool loekvangool commented Nov 25, 2020

Long words (like URLs from payment modules) mess up the order notes layout like this:

Before:
image

A word-break fixes it and although it does break the word at the end of the box, it does not take away any information.

After:

image

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Template : admin Relates to admin template labels Nov 25, 2020
kkrieger85
kkrieger85 previously approved these changes Nov 29, 2020
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigifab
Copy link
Contributor

luigifab commented May 16, 2021

For openmage and legacy themes, in Order view and Invoice View, the fix do nothing (for me, Firefox 88), but .note-list li { word-break: break-all; } do the job.

I used the following comments to test: klmjkljkljjklllkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk and ùmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm .

@fballiano
Copy link
Contributor

@loekvangool would you add @luigifab patch to this?

@loekvangool
Copy link
Contributor Author

Done

@fballiano fballiano requested a review from kkrieger85 May 4, 2022 07:57
@fballiano fballiano merged commit 98ede1c into OpenMage:1.9.4.x May 19, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit 98ede1c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants