Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes PHP7.4 deprecated nested ternary operators #1393

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Fixes PHP7.4 deprecated nested ternary operators #1393

merged 2 commits into from
Jan 17, 2021

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 13, 2021 •
edited
Loading

Description (*)

Fixes:

PHP Deprecated: Unparenthesized a ? b : c ? d : e is deprecated. Use either (a ? b : c) ? d : e or a ? b : (c ? d : e) in ./lib/Zend/Service/Console/Command.php on line 223

Manual testing scenarios (*)

  1. https://github.com/OpenMage/magento-lts/pull/1392/checks?check_run_id=1692086971 (PHP7.4)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the PHP 7.x Related to PHP 7.x label Jan 13, 2021
colinmollenhour
colinmollenhour approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code should just be deleted but will just approve for now.. :)

@Flyingmana Flyingmana merged commit 62d9431 into OpenMage:1.9.4.x Jan 17, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 62d9431. ± Comparison against base commit 59983f9.

@sreichel sreichel deleted the php74/nested-operators branch January 17, 2021 16:13
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 17, 2021
@sreichel sreichel mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: lib/* Relates to lib/* PHP 7.x Related to PHP 7.x
Projects
None yet
Milestone
Release 19.4.10 / 20.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @Flyingmana @kiatng