Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc getCountry - returning string instead of int #1454

Merged
merged 5 commits into from
Apr 8, 2021

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Feb 6, 2021

Description (*)

Fixing wrong ducumentation of method getCountry. This method returing string instead of int.

image

Database definition:

`country_id` varchar(2) DEFAULT NULL COMMENT 'Country Id',

Manual testing scenarios (*)

not necessary

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Customer Relates to Mage_Customer label Feb 6, 2021
@Sekiphp Sekiphp changed the title Fix doc forgetCountryId - returning string instead of int Fix doc getCountry - returning string instead of int Feb 6, 2021
@luigifab
Copy link
Contributor

luigifab commented Feb 7, 2021

Why you have pushed 5 commits? 👀

@midlan
Copy link
Contributor

midlan commented Feb 16, 2021

worth to note that it might return string that contains integer

@sreichel
Copy link
Contributor

Thanks.

I know, not all of the DOC block changes/additions have been tested. This was just not possible for thousands of changes.

Correction/fixess are planed (#784) , but there is no time ATM. Thanks for your commit, :)

@fballiano
Copy link
Contributor

let's merge it and get rid of it no?

@Flyingmana Flyingmana merged commit 28ecfb5 into OpenMage:1.9.4.x Apr 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 28ecfb5. ± Comparison against base commit 2310733.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Relates to Mage_Customer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants