Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce getId calls #1571

Merged
merged 1 commit into from
May 4, 2021
Merged

Reduce getId calls #1571

merged 1 commit into from
May 4, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Apr 27, 2021 •
edited
Loading

Description

This PR reduce calls for getId.
On a category page with ~80 products, this change remove the following result from BlackFire:

getid

OpenMage 20.0.8 / PHP 7.4.6

Manual testing scenarios

Go to any pages where product are visible.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches label Apr 27, 2021
@kiatng kiatng added the performance Performance related label Apr 28, 2021
@Flyingmana Flyingmana merged commit 266b27d into OpenMage:1.9.4.x May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  0 💤 ±0  0 ❌ ±0  2 🔥 +2 

Results for commit 266b27d. ± Comparison against base commit f71321b.

@luigifab luigifab deleted the reduce-getid branch May 4, 2021 10:02
@luigifab luigifab mentioned this pull request Feb 2, 2023
Merged
4 tasks
This was referenced Apr 9, 2023
Merged
Merged
@luigifab luigifab mentioned this pull request Apr 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfksk jfksk jfksk approved these changes

@kiatng kiatng kiatng approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches performance Performance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigifab @Flyingmana @kiatng @jfksk