Added required PHP modules to composer.json

[fballiano]

Everything is explained in ISSUE #2017

[fballiano]

@tmotyl could you help me updating the composer lock?

[tmotyl]

composer update —lock should be enough

[fballiano]

to be able to run composer update --lock I had to update the composer.json file again adding a few things, do you think it's ok?

[ADDISON74]

This is the list of PHP extensions installed in production on my servers (PHP 7.0 to 7.4):

php7.x-cgi - server-side, HTML-embedded scripting language (CGI binary)
php7.x-cli - command-line interpreter for the PHP scripting language
php7.x-common - documentation, examples and common module for PHP
php7.x-curl - CURL module for PHP
php7.x-fpm - server-side, HTML-embedded scripting language (FPM-CGI binary)
php7.x-gd - GD module for PHP
php7.x-json - JSON module for PHP
php7.x-mbstring - MBSTRING module for PHP
php7.x-mcrypt - libmcrypt module for PHP
php7.x-mysql -  MySQL module for PHP
php7.x-opcache - Zend OpCache module for PHP
php7.x-readline - readline module for PHP
php7.x-soap - SOAP module for PHP
php7.x-xml - DOM, SimpleXML, WDDX, XML, and XSL module for PHP
php7.x-zip - Zip module for PHP

IMPORTANT: Starting with PHP 7.2+ mcrypt needs to be disabled (in Linux command phpdismod php7.x-mcrypt or by editing php.ini file).

[tmotyl]

I can't say whether the change of ""magento-root-dir": "."" is correct or not, I'm not sure what it does.

[fballiano]

I can't say whether the change of ""magento-root-dir": "."" is correct or not, I'm not sure what it does.

it seems to be where composer installs magento, it's weird but without that any composer command wouldn't work

[luigifab]

I think that the good composer command is: composer update --lock --no-install
With it, magento-root-dir changes are not required.

[fballiano]

Did as @luigifab and worked flawlessly, thank you so much! :-)

[luigifab]

If we add that, peoples need to install php-ftp and php-iconv, right?
I never installed them, and I don't want to install them (ok I use --ignore-platform-reqs, but...).

[fballiano]

If we add that, peoples need to install php-ftp and php-iconv, right? I never installed them, and I don't want to install them (ok I use --ignore-platform-reqs, but...).

I think so. But you sent me the list of extensions :-)

[fballiano]

would do I have to do about this? I don't care about this PR but I created cause @Flyingmana requested it in #2017 so we do something or close both.
I think our implementation of composer is just weird so I don't really care about it

[luigifab]

Remove ext-ftp and ext-iconv, zlib? I don't know, and let's go.

[fballiano]

mmm but it seems to me that the ConfigurableSwatches module uses iconv and it is required by app/code/core/Mage/Install/etc/install.xml

[Flyingmana]

so following https://magento.stackexchange.com/questions/61377/minimum-number-of-php-modules-needed-to-run-magento it seems we got all the commonly needed exceptions.
Only ftp seems to not be commonly needed, so if we remove this one I think the PR is ready.

Thanks for all the work already :)

[fballiano]

ftp extension removed

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit e06fe2d. ± Comparison against base commit 8624d5e.