Removed getQty() from Mage_Wishlist_IndexController #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a controller, introduced with PR #1915
fballiano
requested review from
colinmollenhour,
Flyingmana,
kiatng,
kkrieger85,
sreichel and
tmotyl
elidrissidev
approved these changes
May 10, 2022
luigifab
approved these changes
May 10, 2022
|
@elidrissidev if you like phpstan please review #2055 :) |
kiatng
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1915 introduced a getQty() method in Mage_Wishlist_IndexController which triggers a PHPStan error https://github.com/OpenMage/magento-lts/actions/runs/2299769470 and shouldn't be in the controller anyway.
I've removed it.