Fixed issue #2212 SQLSTATE[42S22]: Column not found: 1054 Unknown col…

[kiatng]

…umn 'password_created_at' in 'field list'

Description (*)

The exception is because password_created_at is not a static attribute, it's not in the customer_entity table,

Related Pull Requests

PR #546

Fixed Issues (if relevant)

Issue #2212

Manual testing scenarios (*)

Questions or comments

[fballiano]

I'd like to hear from @colinmollenhour before merging but thanks!

[fballiano]

would it be possible not to have the 2 joins? using a query like this would be enough?

select customer_entity_int.value from eav_attribute JOIN customer_entity_int ON (eav_attribute.attribute_id=customer_entity_int.attribute_id and eav_attribute.entity_type_id=customer_entity_int.entity_type_id) where eav_attribute.attribute_code='password_created_at' and eav_attribute.entity_type_id=1 and customer_entity_int.entity_id=?

it's with a single join instead of two.

dunno if the performance is so much better or worse.

[kiatng]

@fballiano I do not see how it can be only one join because:

$field = $this->_getReadAdapter()->getIfNullSql('t2.value', 't0.created_at');

We need to take created_at from the main table (t0) customer_entity in case password_created_at (t2.value) is null. Or am I missing something?

[fballiano]

tested and working

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit ae234cc. ± Comparison against base commit 1bcaac5.