-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xml validation problems #2242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Api
PageRelates to Mage_Api
Component: Catalog
Relates to Mage_Catalog
Component: CatalogInventory
Relates to Mage_CatalogInventory
Component: Checkout
Relates to Mage_Checkout
Component: Core
Relates to Mage_Core
Component: Customer
Relates to Mage_Customer
Component: Directory
Relates to Mage_Directory
Component: Downloadable
Relates to Mage_Downloadable
Component: Sales
Relates to Mage_Sales
Component: Tag
Relates to Mage_Tag
labels
Jun 20, 2022
addison74
previously approved these changes
Jun 21, 2022
kiatng
previously requested changes
Jun 26, 2022
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
Co-authored-by: Ng Kiat Siong <[email protected]>
@kiatng I think I commited all your suggestions, thanks! |
fballiano
requested review from
addison74,
colinmollenhour,
kkrieger85,
Sekiphp,
Flyingmana,
sreichel and
tmotyl
June 26, 2022 17:01
Flyingmana
approved these changes
Jul 10, 2022
If a value cannot be assigned to {{var wsdl.name}} then this manual change is absolutely necessary. |
tmewes
approved these changes
Jul 10, 2022
elidrissidev
approved these changes
Jul 12, 2022
elidrissidev
pushed a commit
to elidrissidev/magento-lts
that referenced
this pull request
Jul 22, 2022
Flyingmana
added
the
backwards compatibility
Might affect backwards compatibility for some users
label
Jan 3, 2023
note: changing the schema name to OpenMage was breaking Integrations with external services (reported on a different place, for example here #2539 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards compatibility
Might affect backwards compatibility for some users
Component: Api
PageRelates to Mage_Api
Component: Catalog
Relates to Mage_Catalog
Component: CatalogInventory
Relates to Mage_CatalogInventory
Component: Checkout
Relates to Mage_Checkout
Component: Core
Relates to Mage_Core
Component: Customer
Relates to Mage_Customer
Component: Directory
Relates to Mage_Directory
Component: Downloadable
Relates to Mage_Downloadable
Component: Sales
Relates to Mage_Sales
Component: Tag
Relates to Mage_Tag
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to introduce XML validation as a github workflow, the commonly used technique is running xmllit with something like:
find . -type f -iname '*.xml' | xargs -I '{}' xmllint --noout '{}'
problem is, xmllint is broken because our XMLs have a "name" variable in some places.
Since that variable was always replaced with "Magento" I figured to:
Fixed Issues (if relevant)
This PR is part of the fix for #1918
Manual testing scenarios (*)
You've the command line in the task description.
Also check that APIs work.