Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xml validation problems #2242

Merged
merged 13 commits into from
Jul 12, 2022
Merged

Fix xml validation problems #2242

merged 13 commits into from
Jul 12, 2022

Conversation

fballiano
Copy link
Contributor

We're trying to introduce XML validation as a github workflow, the commonly used technique is running xmllit with something like:

find . -type f -iname '*.xml' | xargs -I '{}' xmllint --noout '{}'

problem is, xmllint is broken because our XMLs have a "name" variable in some places.

Since that variable was always replaced with "Magento" I figured to:

  • change the Magento name in OpenMage
  • hardcode the OpenMage name in the XMLs so that xmllint works without problems

Fixed Issues (if relevant)

This PR is part of the fix for #1918

Manual testing scenarios (*)

You've the command line in the task description.
Also check that APIs work.

@github-actions github-actions bot added Component: Api PageRelates to Mage_Api Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag labels Jun 20, 2022
addison74
addison74 previously approved these changes Jun 21, 2022
kiatng
kiatng previously requested changes Jun 26, 2022
app/code/core/Mage/Api/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Api/etc/wsdl2.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Api/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/CatalogInventory/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Catalog/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Directory/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Downloadable/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/GiftMessage/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Sales/etc/wsdl.xml Outdated Show resolved Hide resolved
app/code/core/Mage/Tag/etc/wsdl.xml Outdated Show resolved Hide resolved
@fballiano
Copy link
Contributor Author

@kiatng I think I commited all your suggestions, thanks!

@addison74
Copy link
Contributor

If a value cannot be assigned to {{var wsdl.name}} then this manual change is absolutely necessary.

@fballiano fballiano merged commit 4af8207 into OpenMage:1.9.4.x Jul 12, 2022
@fballiano fballiano deleted the fix_xmllint_problems branch July 12, 2022 14:11
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 4af8207. ± Comparison against base commit 0c0eef8.

elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Jul 22, 2022
@Flyingmana Flyingmana added the backwards compatibility Might affect backwards compatibility for some users label Jan 3, 2023
@Flyingmana
Copy link
Contributor

Flyingmana commented Jan 3, 2023

note: changing the schema name to OpenMage was breaking Integrations with external services (reported on a different place, for example here #2539 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards compatibility Might affect backwards compatibility for some users Component: Api PageRelates to Mage_Api Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants