Removed Mage_Backup module

.all-contributorsrc

@@ -1342,6 +1342,15 @@
       "contributions": [
         "code"
       ]
+    },
+    {
+      "login": "discountscott",
+      "name": "Scott Moore",
+      "avatar_url": "https://avatars.githubusercontent.com/u/5454596?v=4",
+      "profile": "https://github.com/discountscott",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "contributorsPerLine": 7

.github/labeler.yml

@@ -95,12 +95,6 @@
   - app/design/frontend/*/*/template/authorizenet/*
   - app/design/frontend/*/*/template/authorizenet/**/*
 
-'Component: Backup':
-  - app/code/core/Mage/Backup/*
-  - app/code/core/Mage/Backup/**/*
-  - app/design/adminhtml/*/*/template/backup/*
-  - app/design/adminhtml/*/*/template/backup/**/*
-
 'Component: Bundle':
   - app/code/core/Mage/Bundle/*
   - app/code/core/Mage/Bundle/**/*

.github/phpstan-baseline.neon

@@ -70,16 +70,6 @@ parameters:
 			count: 2
 			path: ../app/code/core/Mage/Adminhtml/Block/Api/User/Edit/Tab/Roles.php
 
-		-
-			message: "#^Cannot call method addJs\\(\\) on Mage_Core_Block_Abstract\\|false\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/Block/Backup/Dialogs.php
-
-		-
-			message: "#^Method Mage_Adminhtml_Block_Widget_Grid\\:\\:setDefaultSort\\(\\) invoked with 2 parameters, 1 required\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/Block/Backup/Grid.php
-
 		-
 			message: "#^Access to an undefined property Mage_Adminhtml_Block_Catalog_Category_Tab_Design\\:\\:\\$_category\\.$#"
 			count: 1
@@ -510,11 +500,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php
 
-		-
-			message: "#^PHPDoc tag @param references unknown parameter\\: \\$resourcePath$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/Block/Notification/Window.php
-
 		-
 			message: "#^Method Mage_Adminhtml_Block_Page\\:\\:getLang\\(\\) has invalid return type unknown\\.$#"
 			count: 1
@@ -1495,11 +1480,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Adminhtml/Helper/Dashboard/Abstract.php
 
-		-
-			message: "#^Method Mage_Adminhtml_Helper_Data\\:\\:prepareFilterString\\(\\) has invalid return type data\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/Helper/Data.php
-
 		-
 			message: "#^Method Mage_Adminhtml_Model_Config\\:\\:getSection\\(\\) should return Varien_Simplexml_Element but return statement is missing\\.$#"
 			count: 1
@@ -1665,26 +1645,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Adminhtml/controllers/Cms/PageController.php
 
-		-
-			message: "#^Call to method _saveSessionCurrentPath\\(\\) on an unknown class Mage_Adminhtml_Cms_Page_Wysiwyg_ImagesController\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/controllers/Cms/Wysiwyg/ImagesController.php
-
-		-
-			message: "#^Call to method loadLayout\\(\\) on an unknown class Mage_Adminhtml_Cms_Page_Wysiwyg_ImagesController\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/controllers/Cms/Wysiwyg/ImagesController.php
-
-		-
-			message: "#^Method Mage_Adminhtml_Cms_Wysiwyg_ImagesController\\:\\:_initAction\\(\\) has invalid return type Mage_Adminhtml_Cms_Page_Wysiwyg_ImagesController\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/controllers/Cms/Wysiwyg/ImagesController.php
-
-		-
-			message: "#^Method Mage_Adminhtml_Cms_Wysiwyg_ImagesController\\:\\:_saveSessionCurrentPath\\(\\) has invalid return type Mage_Adminhtml_Cms_Page_Wysiwyg_ImagesController\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/controllers/Cms/Wysiwyg/ImagesController.php
-
 		-
 			message: "#^Method Mage_Adminhtml_CustomerController\\:\\:cartAction\\(\\) should return string but return statement is missing\\.$#"
 			count: 1
@@ -1700,11 +1660,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Adminhtml/controllers/IndexController.php
 
-		-
-			message: "#^Method Mage_Adminhtml_JsonController\\:\\:countryRegionAction\\(\\) should return string but return statement is missing\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Adminhtml/controllers/JsonController.php
-
 		-
 			message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#"
 			count: 1
@@ -2165,91 +2120,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php
 
-		-
-			message: "#^PHPDoc tag @param has invalid value \\(string fileName\\)\\: Unexpected token \"fileName\", expected variable at offset 61$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Backup.php
-
-		-
-			message: "#^PHPDoc tag @param has invalid value \\(string filePath\\)\\: Unexpected token \"filePath\", expected variable at offset 91$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Backup.php
-
-		-
-			message: "#^Variable \\$filePath might not be defined\\.$#"
-			count: 4
-			path: ../app/code/core/Mage/Backup/Model/Backup.php
-
-		-
-			message: "#^Call to an undefined method Varien_Data_Collection\\:\\:addTargetDir\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Fs/Collection.php
-
-		-
-			message: "#^Call to an undefined method Mage_Backup_Interface\\:\\:setRootDir\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Observer.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getFooter\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getHeader\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getPartInsertSql\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getTableCreateScript\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getTableCreateSql\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getTableDataAfterSql\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getTableDataBeforeSql\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getTableDropSql\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:getTableForeignKeysSql\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:turnOnReadCommittedMode\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to an undefined method Mage_Core_Model_Resource_Helper_Abstract\\:\\:turnOnSerializableMode\\(\\)\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
-		-
-			message: "#^Call to method Varien_Db_Adapter_Pdo_Mysql\\:\\:rollback\\(\\) with incorrect case\\: rollBack$#"
-			count: 1
-			path: ../app/code/core/Mage/Backup/Model/Resource/Db.php
-
 		-
 			message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getOptionsCollection\\(\\)\\.$#"
 			count: 1
@@ -2495,11 +2365,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php
 
-		-
-			message: "#^Method Mage_Captcha_Adminhtml_RefreshController\\:\\:refreshAction\\(\\) should return null but return statement is missing\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php
-
 		-
 			message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:getImgSrc\\(\\)\\.$#"
 			count: 1
@@ -3352,7 +3217,7 @@ parameters:
 
 		-
 			message: "#^Binary operation \"\\*\" between string and 0\\.3 results in an error\\.$#"
-			count: 2
+			count: 1
 			path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php
 
 		-
@@ -3517,7 +3382,7 @@ parameters:
 
 		-
 			message: "#^Binary operation \"\\*\" between string and 0\\.3 results in an error\\.$#"
-			count: 2
+			count: 1
 			path: ../app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php
 
 		-
@@ -3760,11 +3625,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Checkout/Block/Links.php
 
-		-
-			message: "#^PHPDoc tag @param has invalid value \\(\\$item\\)\\: Unexpected token \"\\$item\", expected type at offset 18$#"
-			count: 2
-			path: ../app/code/core/Mage/Checkout/Block/Multishipping/Addresses.php
-
 		-
 			message: "#^Call to an undefined method Mage_Core_Helper_Abstract\\:\\:displayCartBothPrices\\(\\)\\.$#"
 			count: 1
@@ -5470,11 +5330,6 @@ parameters:
 			count: 2
 			path: ../app/code/core/Mage/Newsletter/Model/Resource/Queue.php
 
-		-
-			message: "#^Call to method Zend_Db_Select\\:\\:where\\(\\) with incorrect case\\: Where$#"
-			count: 1
-			path: ../app/code/core/Mage/Newsletter/Model/Resource/Subscriber.php
-
 		-
 			message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getAttributeId\\(\\)\\.$#"
 			count: 3
@@ -5625,16 +5480,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Payment/Helper/Data.php
 
-		-
-			message: "#^PHPDoc tag @param has invalid value \\(\\$a\\)\\: Unexpected token \"\\$a\", expected type at offset 18$#"
-			count: 1
-			path: ../app/code/core/Mage/Payment/Helper/Data.php
-
-		-
-			message: "#^PHPDoc tag @param has invalid value \\(\\$b\\)\\: Unexpected token \"\\$b\", expected type at offset 35$#"
-			count: 1
-			path: ../app/code/core/Mage/Payment/Helper/Data.php
-
 		-
 			message: "#^Comparison operation \"\\<\" between \\(array\\|float\\|int\\) and 0\\.0001 results in an error\\.$#"
 			count: 1
@@ -7005,11 +6850,6 @@ parameters:
 			count: 1
 			path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php
 
-		-
-			message: "#^Variable \\$attribute in empty\\(\\) always exists and is not falsy\\.$#"
-			count: 1
-			path: ../app/code/core/Mage/Sales/Model/Resource/Order/Abstract.php
-
 		-
 			message: "#^Cannot call method updateOnRelatedRecordChanged\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#"
 			count: 1

.github/phpstan.neon

@@ -11,7 +11,6 @@ parameters:
          - %currentWorkingDirectory%/app/code/core/Mage/Api
          - %currentWorkingDirectory%/app/code/core/Mage/Api2
          - %currentWorkingDirectory%/app/code/core/Mage/Authorizenet
-         - %currentWorkingDirectory%/app/code/core/Mage/Backup
          - %currentWorkingDirectory%/app/code/core/Mage/Bundle
          - %currentWorkingDirectory%/app/code/core/Mage/Captcha
          - %currentWorkingDirectory%/app/code/core/Mage/Catalog
@@ -43,7 +42,6 @@ parameters:
          - %currentWorkingDirectory%/app/code/core/Mage/Newsletter
          - %currentWorkingDirectory%/app/code/core/Mage/Oauth
          - %currentWorkingDirectory%/app/code/core/Mage/Page
-         - %currentWorkingDirectory%/app/code/core/Mage/PageCache
          - %currentWorkingDirectory%/app/code/core/Mage/Paygate
          - %currentWorkingDirectory%/app/code/core/Mage/Payment
          - %currentWorkingDirectory%/app/code/core/Mage/Paypal
@@ -92,9 +90,6 @@ parameters:
         # Class phpseclib\Net\SSH2 not found.
         - */Paypal/Model/Report/Settlement.php
 
-        # Class backup/db was not found while trying to analyse it
-        - */Adminhtml/controllers/System/BackupController.php
-
         # Dataflow/Model/Convert/Iterator.php
         - */Dataflow/Model/Convert/Iterator.php
 

.github/workflows/xml_validate.yml

@@ -0,0 +1,17 @@
+name: XML Validation
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+
+    steps:
+    - name: "Checkout repository"
+      uses: actions/checkout@master
+    - name: "Install xmllint"
+      run: "sudo apt-get -y install libxml2-utils"
+    - name: "Validate XMLs"
+      run: "find . -type f -iname '*.xml' | xargs -I '{}' xmllint --noout '{}'"

.gitignore

@@ -1,13 +1,54 @@
+# Visual Studio Code
+.vscode/*
+!.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/launch.json
+!.vscode/extensions.json
+!.vscode/*.code-snippets
+
+# Local History for Visual Studio Code
+.history/
+
+# Built Visual Studio Code Extensions
+*.vsix
+
+# PhpStorm
+.idea
+
+# Openmage config
 /app/etc/local.xml
-/media/catalog
-/media/captcha
-/media/css
-/media/css_secure
-/media/email/logo
-/media/favicon
-/media/js
-/media/sales/store/logo
-/media/sales/store/logo_html
-/media/wysiwyg
+
+# Add a base setup for running unit Tests with code coverage and send them to SonarCloud
+# https://github.com/OpenMage/magento-lts/pull/1836
+/dev/testfield
+/dev/tests/clover.xml
+/dev/tests/crap4j.xml
+/dev/tests/junit.xml
+
+# Add Gitpod online IDE config
+# https://github.com/OpenMage/magento-lts/pull/1836
+/dev/gitpod/docker-magento
+/dev/gitpod/.env
+
+# Add development environment setup files and README
+# https://github.com/OpenMage/magento-lts/pull/1012
+/dev/openmage/docker-magento
+/dev/openmage/.env
 /dev/tests/functional/generated
 /dev/tests/functional/vendor
+
+/media/*
+!/media/.htaccess
+!/media/custom_options/.htaccess
+!/media/customer/.htaccess
+!/media/dhl/logo.jpg
+!/media/downloadable/.htaccess
+
+/var/*
+!/var/.htaccess
+
+# composer
+/vendor
+
+# ddev
+.ddev/config.yaml