Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing special price in product mass attribute update #2287

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Fix editing special price in product mass attribute update #2287

merged 1 commit into from
Jul 9, 2022

Conversation

fballiano
Copy link
Contributor

Everything is explained in #2286

This PR modified the "special-price-validation" checking that the "original price" input has a value (before it would only check that the original price existed).

@github-actions github-actions bot added the JavaScript Relates to js/* label Jul 8, 2022
@addison74 addison74 linked an issue Jul 8, 2022 that may be closed by this pull request
@fballiano fballiano merged commit 8624d5e into OpenMage:1.9.4.x Jul 9, 2022
@fballiano fballiano deleted the issue_2286 branch July 9, 2022 11:44
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 8624d5e. ± Comparison against base commit 5bf1ab5.

elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't edit special price when mass editing product attributes
3 participants