Remove DISCLAIMER and change Magento -> OpenMage in header

[justinbeaty]

Description (*)

From discussion #2276

Updated file headers to change Magento -> OpenMage and remove the DISCLAIMER about modifying core files. This removed about 1.9MB in disk space.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Check out this branch and run:

git diff -U0 HEAD~1 | grep '^[+-]' | grep -Ev '^(--- a/|\+\+\+ b/)' | awk '!x[$0]++'

That will print all unique changes made in this PR. You should only see comment changes. I will post the output in a follow up comment.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[justinbeaty]

Here's the output of the git diff line to verify only comment changes were made in this PR:

$ git diff -U0 HEAD~1 | grep '^[+-]' | grep -Ev '^(--- a/|\+\+\+ b/)' | awk '!x[$0]++'

- * Magento
+ * OpenMage
- * DISCLAIMER
- *
- * Do not edit or add to this file if you wish to upgrade Magento to newer
- * versions in the future. If you wish to customize Magento for your
- * needs please refer to http://www.magento.com for more information.
-# Magento
+# OpenMage
-# DISCLAIMER
-#
-# Do not edit or add to this file if you wish to upgrade Magento to newer
-# versions in the future. If you wish to customize Magento for your
-# needs please refer to http://www.magento.com for more information.
-// Magento
+// OpenMage
-// DISCLAIMER
-//
-// Do not edit or add to this file if you wish to upgrade Magento to newer
-// versions in the future. If you wish to customize Magento for your
-// needs please refer to http://www.magento.com for more information.

[justinbeaty]

Here is the script I used to create this PR in case anyone is interested: https://gist.github.com/justinbeaty/9e34aaa02958f14127288c930ea2ea7f

Pretty similar to the script included in #2295

[ADDISON74]

I agree with this PR but to approve it I have to go through all the 5000 files. The bad part is that in the browser GitHub loads only 3000 files and it takes time. In the future such big changes should be limited to a number of files in order to be browsed.

PS - It is funny to see how slow it is my desktop loading the diff page. Chrome uses 2.2 GB of memory and the processor is running at 10% (Ryzen 9 5000).

[justinbeaty]

@ADDISON74 I think your eyes will bleed if you try to manually check all 8,416 files and your computer will melt if you try and load it in the browser.

This is why I provided the command to condense the changes to only unique lines. I used these two StackOverflow links for the command: https://stackoverflow.com/a/26622262 and https://stackoverflow.com/a/11532197

Edit: Another way to quickly check is this:

$ git diff --stat HEAD~1 | cut -f2 -d"|" | sort -u

 8 +-------
 8416 files changed, 8416 insertions(+), 58912 deletions(-)

This will show every file that was modified had exactly 8 changes (-1 line Magento, +1 line OpenMage, -6 lines DISCLAIMER)

[justinbeaty]

Rebased after #2296 and all checks are green! ✅

[fballiano]

checked it and everything seems ok, @justinbeaty do you want me to fix the conflict or you prefer rebasing it?

[justinbeaty]

@fballiano I've rebased and fixed the conflict.

[fballiano]

checked the diff and looks fine

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit e6f0851. ± Comparison against base commit 8d2a11b.