-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a notice #2318
Fixes a notice #2318
Conversation
After this commit OpenMage@de06e67 the code in the checkout has not been updated to look for the session validation data in the new location. As such a PHP notice is generated. This PR avoids the notice by updating the code to fetch the session validation data in the correct place.
Is this supposed to be a fix for #2285? If so please link it with this PR. |
@elidrissidev Yes, it is! I missed that issue, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and all good.
@azambon made the suggested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description (*)
After this commit de06e67 the code in the checkout has not been updated to look for the session validation data in the new location. As such a PHP notice is generated.
This PR avoids the notice by updating the code to fetch the session validation data in the correct place.
Related Pull Requests
Fixed Issues (if relevant)
Fixes issue #2285
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)