Fix phpdoc for saveAttribute()

[Caprico85]

Description (*)

saveAttribute() in Mage_Sales_Model_Resource_Order_Abstract only specifies string as type for $attribute. As you can see a few lines later, it also takes string arrays.

public function saveAttribute(Mage_Core_Model_Abstract $object, $attribute)
{
    if ($attribute instanceof Mage_Eav_Model_Entity_Attribute_Abstract) {
        $attribute = $attribute->getAttributeCode();
    }

    if (is_string($attribute)) {
        $attribute = array($attribute);
    }

    if (is_array($attribute) && !empty($attribute)) {                    // <-- see the is_array() here
        $this->beginTransaction();

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[elidrissidev]

This change also happens to solve a phpstan error that was previously ignored so we need to remove it from the baseline file below:

magento-lts/.github/phpstan-baseline.neon

Lines 7013 to 7017 in 0d99717

	-
	message: "#^Variable \\$attribute in empty\\(\\) always exists and is not falsy\\.$#"
	count: 1
	path: ../app/code/core/Mage/Sales/Model/Resource/Order/Abstract.php

[Caprico85]

You're right. I updated my PR to include Mage_Eav_Model_Entity_Attribute_Abstract as additional type and remove the phpstan ignore.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 31c8018. ± Comparison against base commit 0d99717.