Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flat.php to correct bug #2337 #2338

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Update Flat.php to correct bug #2337 #2338

merged 1 commit into from
Jul 26, 2022

Conversation

matteorossi-thespacesm
Copy link
Contributor

@matteorossi-thespacesm matteorossi-thespacesm commented Jul 25, 2022 •
edited by sreichel
Loading

Proposal to correct bug #2337

Description (*)

Add getProductsPosition method to Mage_Catalog_Model_Resource_Category_Flat class

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Uncaught Error: Call to undefined method Mage_Catalog_Model_Resource_Category_Flat::getProductsPosition() #2337

Manual testing scenarios (*)

  1. Call $category->getProductsPosition(); while using Category Flat Table

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@matteorossi-thespacesm
Update Flat.php
648e268 
Proposal to correct bug OpenMage#2337
@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Jul 25, 2022
@sreichel sreichel added the bug label Jul 26, 2022
@fballiano fballiano merged commit e1741e5 into OpenMage:1.9.4.x Jul 26, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit e1741e5. ± Comparison against base commit cc320eb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
bug Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught Error: Call to undefined method Mage_Catalog_Model_Resource_Category_Flat::getProductsPosition()
3 participants
@matteorossi-thespacesm @fballiano @sreichel